Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the count of workbook dashboard in workspace #2314

Merged
merged 1 commit into from
Jul 3, 2019
Merged

fix the count of workbook dashboard in workspace #2314

merged 1 commit into from
Jul 3, 2019

Conversation

minhyun2
Copy link
Contributor

@minhyun2 minhyun2 commented Jul 3, 2019 •
edited
Loading

Description

fix the count of workbook dashboard in workspace

Related Issue :

How Has This Been Tested?

  1. Create a datasource.
  2. Create a dashboard with the datasource.
  3. Check the count of dashboard in workspace
  4. Delete the datasource.
  5. Verify that the number checked in step 3 has decreased by one.

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@minhyun2 minhyun2 added @workspace Component Name : Workspace to master labels Jul 3, 2019
@kyungtaak
Copy link
Contributor

run build
deploy to 5

@kyungtaak kyungtaak added the testbed5 Review Test Server 5 label Jul 3, 2019
ufoscw
ufoscw approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@ufoscw ufoscw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ufoscw ufoscw merged commit 45ede03 into 3.2.x Jul 3, 2019
alchan-lee pushed a commit that referenced this pull request Jul 5, 2019
@minhyun2 @alchan-lee
#2314 fix the count of workbook dashboard in workspace
eafc04b
@alchan-lee alchan-lee deleted the fn-fix_workspace_dashboard_count branch August 2, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufoscw ufoscw ufoscw approved these changes

@kyungtaak kyungtaak Awaiting requested review from kyungtaak

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
testbed5 Review Test Server 5 to master @workspace Component Name : Workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minhyun2 @kyungtaak @ufoscw