Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting cookie domain in external login page #2325

Merged
merged 1 commit into from
Jul 8, 2019
Merged

fix setting cookie domain in external login page #2325

merged 1 commit into from
Jul 8, 2019

Conversation

minhyun2
Copy link
Contributor

@minhyun2 minhyun2 commented Jul 7, 2019

Description

fix setting cookie domain in external login page

Related Issue :

How Has This Been Tested?

After logging in through the external login page, check to see if you can log out of Discovery.

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@minhyun2 minhyun2 added bug Something isn't working @common Component Name : Common labels Jul 7, 2019
@minhyun2 minhyun2 added the testbed2 Review Test Server 2 label Jul 7, 2019
@minhyun2
Copy link
Contributor Author

minhyun2 commented Jul 7, 2019

run build
deploy to 2

@alchan-lee alchan-lee merged commit 27a1201 into master Jul 8, 2019
@minhyun2 minhyun2 added the need to cherry-pick This change need to merge into another base branch. label Jul 22, 2019
alchan-lee pushed a commit that referenced this pull request Jul 23, 2019
@minhyun2 @alchan-lee
#2325 Fix setting cookie domain in external login page
d00d995
@alchan-lee alchan-lee deleted the fn-fix_external_login_cookie_domain branch August 2, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@alchan-lee alchan-lee alchan-lee approved these changes

@ufoscw ufoscw Awaiting requested review from ufoscw

Assignees
No one assigned
Labels
bug Something isn't working @common Component Name : Common need to cherry-pick This change need to merge into another base branch. testbed2 Review Test Server 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minhyun2 @kyungtaak @alchan-lee