Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2294 check timestamp datasource column #2356

Merged
merged 1 commit into from Jul 17, 2019
Merged

#2294 check timestamp datasource column #2356

merged 1 commit into from Jul 17, 2019

Conversation

minhyun2
Copy link
Contributor

Description

Change timestamp column validation logic if the data contains null / empty values

Related Issue : #2294

How Has This Been Tested?

Create a datasource with null / empty value in the timestamp column.

Need additional checks?

Check if the percentage of empty values ​​is more than or less than 50%

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@minhyun2 minhyun2 added the @datasource Component Name : Datasource/Connection Management label Jul 15, 2019
@ufoscw ufoscw added the testbed5 Review Test Server 5 label Jul 15, 2019
@ufoscw
Copy link
Contributor

ufoscw commented Jul 15, 2019

run build
deploy to 5

@kyungtaak kyungtaak merged commit eb76819 into master Jul 17, 2019
@alchan-lee alchan-lee deleted the f#2294-check_timestamp_datasource_column branch August 2, 2019 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@ufoscw ufoscw ufoscw approved these changes

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
@datasource Component Name : Datasource/Connection Management testbed5 Review Test Server 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minhyun2 @ufoscw @kyungtaak