Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot loading and add name title #2385

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Conversation

brandon-wonjune
Copy link
Contributor

Description

  • 워크스페이스 화면에서 이름이 긴 workbook, workbench 등 에 대해 말줄임 표시가 나타나지 않는 현상 수정
  • lnb에서 데이터스냅샷 접근시 로딩이 사라지지 않는 현상 수정

Related Issue :

통합테스트

How Has This Been Tested?

  1. 개인 워크스페이스 화면 진입
  2. 이름이 긴 이름의 book에 말줄임 표시가 표시되는지 확인 (커서를 올렸을 경우 tooltip이 표시되는지 확인)
  3. LNB에서 '데이터스냅샷'을 클릭시 데이터스냅샷 화면에서 로딩이 사라지는지 확인

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@brandon-wonjune brandon-wonjune added the bug Something isn't working label Jul 23, 2019
@brandon-wonjune brandon-wonjune requested review from kyungtaak, eltriny and a team July 23, 2019 08:50
@alchan-lee
Copy link
Contributor

run build
deploy to 2

@alchan-lee alchan-lee added the testbed2 Review Test Server 2 label Jul 24, 2019
@kyungtaak kyungtaak merged commit 61dc7a0 into 3.2.x Jul 25, 2019
@alchan-lee alchan-lee deleted the fn-fix_snapshot_and_workspace branch August 2, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testbed2 Review Test Server 2 to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants