Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#251 decimal places not working #271

Merged
merged 7 commits into from
Sep 19, 2018
Merged

Conversation

dave-taeho
Copy link
Contributor

Description

숫자 포맷에서 소수점 자리를 설정하였을 때, 적용되도록 개선합니다.

Related Issue : #251

How Has This Been Tested?

  1. (공통) 차트생성
  2. 숫자 포맷 (number format)에서 소수점 자리(Decimal place) 설정
  3. 범례,축, 레이블, 툴팁에서 소수점 자리수가 표시되는지 확인합니다.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@kyungtaak kyungtaak added testbed4 Review Test Server 4 @dashboard Component Name : Dashboard / Chart labels Sep 18, 2018
ufoscw
ufoscw previously approved these changes Sep 19, 2018
Copy link
Contributor

@ufoscw ufoscw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@esezin esezin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. text table(표)에서 소수점 자리가 적용되지 않습니다.
  2. Combine Chart (결합차트)의 보조축에 소수점 자리가 적용되지 않습니다.
  3. Network Diagram (네트워크 다이어그램)의 연결값 데이터 레이블에 소수점 자리가 적용되지 않습니다.

댓글에 참고 이미지 스크린샷을 첨부하도록하겠습니다.

@esezin
Copy link

esezin commented Sep 19, 2018

  1. 표에서의 미적용 스크린샷
    git-251-01

  2. 결합차트에서의 미적용 스크린샷
    git-251-02

  3. 네트워크 다이어그램에서의 미적용 스크린샷
    git-251-03

@ufoscw
Copy link
Contributor

ufoscw commented Sep 19, 2018

우선 PR을 클로즈하고 조치 후 다시 오픈해주세요

@ufoscw ufoscw closed this Sep 19, 2018
@ufoscw ufoscw removed the testbed4 Review Test Server 4 label Sep 19, 2018
@juheeko9
Copy link
Contributor

juheeko9 commented Sep 19, 2018

@esezin 그리드차트의 소수점미적용 이슈는 #37 에서 반영할 예정입니다.

@dave-taeho
Copy link
Contributor Author

컴파인, 네트워크 차트 포멧 적용하였습니다.
빌드 부탁드립니다.

esezin
esezin previously approved these changes Sep 19, 2018
@eltriny eltriny added the testbed2 Review Test Server 2 label Sep 19, 2018
@eltriny
Copy link
Contributor

eltriny commented Sep 19, 2018

run build
deploy to 2

@ufoscw ufoscw self-requested a review September 19, 2018 13:03
Copy link
Contributor

@ufoscw ufoscw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ufoscw ufoscw merged commit ba1d9d4 into 3.0.3 Sep 19, 2018
@alchan-lee alchan-lee deleted the #251-decimal_places_not_working branch September 27, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dashboard Component Name : Dashboard / Chart testbed2 Review Test Server 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants