Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'VIEW' table count target of Postgresql. #2868

Merged
merged 1 commit into from Nov 17, 2019
Merged

Added 'VIEW' table count target of Postgresql. #2868

merged 1 commit into from Nov 17, 2019

Conversation

ufoscw
Copy link
Contributor

@ufoscw ufoscw commented Nov 15, 2019

Description

There are more actual tables / views in the workbench, but there are some things that are not displayed in Page Nation.

Related Issue :

How Has This Been Tested?

  1. Create a workbench postgresql.
  2. Verify that the table list is displayed correctly.

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@ufoscw ufoscw added the @workbench Component Name : Workbench label Nov 15, 2019
@ufoscw ufoscw added the testbed5 Review Test Server 5 label Nov 15, 2019
@ufoscw
Copy link
Contributor Author

ufoscw commented Nov 15, 2019

deploy to 5

@ufoscw ufoscw added the need to cherry-pick This change need to merge into another base branch. label Nov 15, 2019
@kyungtaak kyungtaak merged commit e01c12a into master Nov 17, 2019
@alchan-lee alchan-lee deleted the fn-fix_table_count_query_for_postgresql branch November 25, 2019 01:40
alchan-lee pushed a commit that referenced this pull request Dec 5, 2019
@ufoscw @alchan-lee
#2868 add 'VIEW' type for counting table on Postgresql
18b321e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@minhyun2 minhyun2 minhyun2 approved these changes

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
need to cherry-pick This change need to merge into another base branch. testbed5 Review Test Server 5 @workbench Component Name : Workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ufoscw @kyungtaak @minhyun2