Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplication error when creating a datasource with a registered disabled datasource #2905

Merged
merged 1 commit into from
Dec 2, 2019
Merged

fix duplication error when creating a datasource with a registered disabled datasource #2905

merged 1 commit into from
Dec 2, 2019

Conversation

minhyun2
Copy link
Contributor

Description

Fix duplication error when creating a data source for the metatron engine with a registered disabled datasource

Related Issue :

How Has This Been Tested?

  1. Create a datasource from the metatron engine using the physical name of the datasource in the DISABLED state.
  2. When creating a data source, make sure that it works correctly without duplication errors when you click the next button in the preview step.

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@minhyun2 minhyun2 added the @datasource Component Name : Datasource/Connection Management label Nov 25, 2019
@minhyun2 minhyun2 added the testbed5 Review Test Server 5 label Nov 25, 2019
@minhyun2
Copy link
Contributor Author

deploy to 5

@minhyun2 minhyun2 added the need to cherry-pick This change need to merge into another base branch. label Nov 25, 2019
@kyungtaak kyungtaak merged commit 5c899ed into master Dec 2, 2019
alchan-lee pushed a commit that referenced this pull request Dec 5, 2019
@minhyun2 @alchan-lee
#2905 fix duplication error when creating a datasource with a registe…
65958cc 
…red disabled datasource
@alchan-lee alchan-lee deleted the fn-fix_datasource_duplication_error branch December 10, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@ufoscw ufoscw ufoscw approved these changes

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
@datasource Component Name : Datasource/Connection Management need to cherry-pick This change need to merge into another base branch. testbed5 Review Test Server 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minhyun2 @kyungtaak @ufoscw