Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix new notebook error #2948

Merged
merged 1 commit into from
Dec 9, 2019
Merged

fix new notebook error #2948

merged 1 commit into from
Dec 9, 2019

Conversation

minhyun2
Copy link
Contributor

@minhyun2 minhyun2 commented Dec 9, 2019

Description

fix new notebook setup error in a new workspace that has never been set up

Related Issue :

How Has This Been Tested?

Set up a Jupyter notebook in a new workspace that has never been set up.

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@minhyun2 minhyun2 added the @notebook Component Name : Notebook label Dec 9, 2019
@minhyun2 minhyun2 added the testbed4 Review Test Server 4 label Dec 9, 2019
@minhyun2
Copy link
Contributor Author

minhyun2 commented Dec 9, 2019

deploy to 4

@kyungtaak kyungtaak merged commit 3a9a11d into 3.3.x Dec 9, 2019
@alchan-lee alchan-lee deleted the fn-fix_add_notebook_error branch December 10, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyungtaak kyungtaak kyungtaak approved these changes

@pygman86 pygman86 pygman86 approved these changes

@ufoscw ufoscw Awaiting requested review from ufoscw

@alchan-lee alchan-lee Awaiting requested review from alchan-lee

Assignees
No one assigned
Labels
@notebook Component Name : Notebook testbed4 Review Test Server 4 to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minhyun2 @kyungtaak @pygman86