#416 Alias display error when setting chart detail #443

juheeko9 · 2018-10-15T06:52:26Z

Description

kpi차트의 common 옵션패널, secondary indicator 옵션패널에서 설정된 alias로 표현되게 수정
bar차트의 color setting 옵션패널의 color by dimension에서 설정된 alias로 표현되게 수정
bar차트의 data label 옵션패널에서 설정된 alias로 표현되게 수정
bar차트의 tooltip 옵션패널에서 설정된 alias로 표현되게 수정

Related Issue : #416

How Has This Been Tested?

[kpi 차트]

차트화면에서 measure를 한개올리고 kpi차트를 선택
dimension의 alias를 설정합니다.
common setting 옵션패널의 using graphic icons의 목록과 add description 목록에서 설정된 alias로 표현되는지 확인합니다.
set up secondary indicators 옵션패널의 display target에서 설정된 alias로 표현되는지 확인합니다.

[바차트 color setting]

차트화면에서 열선반 : dimension 1개, 교차선반 : measure 1개를 올리고 바차트를 선택
dimension의 alias를 설정합니다.
color setting 옵션패널에서 color by dimension으로 선택합니다.
dimension 리스트에서 설정된 alias로 표현되는지 확인합니다.

[바차트 data label]

차트화면에서 열선반 : dimension 1개, 교차선반 : measure 1개를 올리고 바차트를 선택
dimension, measure의 alias를 설정합니다.
tooltip 옵션패널에서 display label을 모두 선택한 후 설정된 alias로 표현되는지 확인합니다.

[바차트 tooltip]

차트화면에서 열선반 : dimension 1개, 교차선반 : measure 1개를 올리고 바차트를 선택
dimension, measure의 alias를 설정합니다.
data label 옵션패널에서 display label을 모두 선택한 후 설정된 alias로 표현되는지 확인합니다.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project. it will be added soon
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document. it will be added soon
I have added tests to cover my changes.
All new and existing tests passed.

Additional Context

kyungtaak · 2018-10-15T23:18:27Z

run build
deploy to 2

minjung-cho

우측 패널의 컬럼명이 노출되는 곳에서는 '차트 알리아스' > '알리아스' > '컬럼명' 순으로 보여져야 합니다. 현재 '차트 알리아스'도 '알리아스' 인것 처럼 표시되고 있습니다.

…://github.com/metatron-app/metatron-discovery into f#416-alias_display_error_chart

…://github.com/metatron-app/metatron-discovery into f#416-alias_display_error_chart # Conflicts: # discovery-frontend/src/app/page/chart-style/common-option.component.ts

sting009 · 2019-01-10T00:59:58Z

@minjung-cho 해당 내용까지 수정되었습니다.

추가 코멘트 적어주신 내용까지 수정되어, 다시 오픈 하겠습니다.

alchan-lee · 2019-01-11T02:20:08Z

기능 외적으로.. 이 변경건을 master에 적용하시려면
feature 브랜치 자체의 base 브랜치를 옮겨 주셔야 할 듯 합니다.
(github ui에서 target을 바꾸는 것만 으로는 해결이 안됩니다)

feature 브랜치에서 cli를 통해 git rebase --onto <새 베이스 브랜치> <이전 베이스 브랜치>로 옮겨 주셔야 합니다.

ex) git rebase --onto master refs/heads/3.1.1

이렇게 베이스 브랜치를 변경하신 뒤 feature 브랜치에 force push를 해주셔야 합니다.

master에 바로 반영을 하게 되면서 revert / cherry-pick 등이 원활해져야 하는 관계로
merge 커밋에라도 다른 변경건들이 포함된 경우에는 merge 시키지 않게 된 점 양해 부탁드립니다.

* #1077 Make database type icons into common component * #1077 snapshot is using custom API controllers * #1077 snapshot uses always default projection has all properties * #1077 snapshot has the properties of abstracthistoryentity * #1077 merger with master * #1077 Snapshots can only change allowed properties * #1077 work_list returns snapshots was not canceled * #1077 Add ss type icon in snapshot list, fix svg icon component * #416 #443 fix error displaying alias in chart widget * #1092 fix job property guide popup css * #1092 Fix date range format (add T for time) * #1092 remove data range in stagingDB(change to intervals) * #1092 change default data range regex * #1092 fix interval guide icon css error * #1092 fixed guide info, fix granularity service * #1092 add uppercase replace

juheeko9 and others added 5 commits October 15, 2018 11:15

#416 change alias setting in tooltip, datalabel

5e7c32c

#416 fix pie, grid, wordcloud alias error

6c6a18a

#416 set axis name as alias in gauge chart

2adaef1

#416 KPI chart common setting alias error

b5116f7

#416 fix pie alias error

65b473b

juheeko9 requested review from kyungtaak, eltriny and a team October 15, 2018 06:52

kyungtaak added testbed2 Review Test Server 2 @chart Chart Component and Widget labels Oct 15, 2018

minjung-cho reviewed Oct 16, 2018

View reviewed changes

juheeko9 closed this Oct 16, 2018

dave-taeho and others added 12 commits October 17, 2018 13:59

#416 Dashboard alias change option panel

e8a66c8

#416 change alias setting in tooltip

d4979e4

Merge branches '3.0.6' and 'f#416-alias_display_error_chart' of https…

21d9864

…://github.com/metatron-app/metatron-discovery into f#416-alias_display_error_chart

Merge branches '3.0.7' and 'f#416-alias_display_error_chart' of https…

353ee99

…://github.com/metatron-app/metatron-discovery into f#416-alias_display_error_chart

#416 adjust initialize what chart widget

270b1f4

Merge branches '3.0.7' and 'f#416-alias_display_error_chart' of https…

8554616

…://github.com/metatron-app/metatron-discovery into f#416-alias_display_error_chart

Set version to 3.1.0

b609b23

Merge branches '3.1.0' and 'f#416-alias_display_error_chart' of https…

adb7b56

…://github.com/metatron-app/metatron-discovery into f#416-alias_display_error_chart # Conflicts: # discovery-frontend/src/app/page/chart-style/common-option.component.ts

#659 merge from 3.1.1

564de0f

#416 change alias setting in option panel

e11bb66

#416 fix legend, data label bug when change alias

7019c46

#416 master merge

5908a03

sting009 changed the base branch from 3.0.5 to master January 9, 2019 04:52

sting009 requested review from sting009 and choonglee170924 January 9, 2019 04:52

sting009 reopened this Jan 10, 2019

kyungtaak requested a review from alchan-lee January 10, 2019 01:58

sting009 removed the testbed2 Review Test Server 2 label Jan 10, 2019

alchan-lee closed this Jan 11, 2019

sting009 mentioned this pull request Jan 16, 2019

F#416 fix alias display error chart #1258

Merged

9 tasks

kyungtaak pushed a commit that referenced this pull request Jan 17, 2019

#416 #443 fix error displaying alias in chart widget

7230ab6

ufoscw deleted the f#416-alias_display_error_chart branch March 18, 2021 06:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#416 Alias display error when setting chart detail #443

#416 Alias display error when setting chart detail #443

juheeko9 commented Oct 15, 2018

kyungtaak commented Oct 15, 2018

minjung-cho left a comment •

edited

sting009 commented Jan 10, 2019

alchan-lee commented Jan 11, 2019

#416 Alias display error when setting chart detail #443

#416 Alias display error when setting chart detail #443

Conversation

juheeko9 commented Oct 15, 2018

Description

How Has This Been Tested?

Types of changes

Checklist:

Additional Context

kyungtaak commented Oct 15, 2018

minjung-cho left a comment • edited

Choose a reason for hiding this comment

sting009 commented Jan 10, 2019

alchan-lee commented Jan 11, 2019

minjung-cho left a comment •

edited