Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F#553 different dataset information #683

Merged
merged 7 commits into from
Nov 8, 2018

Conversation

sang-hee-lee
Copy link
Contributor

@sang-hee-lee sang-hee-lee commented Nov 7, 2018

Description

fix different dataset information
fix dataflow description on the dataset detail page

Related Issue :

#553 #555

How Has This Been Tested?

1-1.Go to Management > Data Preparation > Dataset
1-2.Click any type of dataset to enter detail page
1-3.See information of the dataset
1-4.Click any dataflow name using the dataset above
1-5.Click the dataset to see detail panel
1-6.See information of the dataset
1-7.Compare two information

This should be tested on all CSV, Excel, StagingDB, Database types.

2-1.Go to Management > Data preparation > Dataset
2-2.Click any dataset used in dataflow has description
2-3.See description of dataflow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. it will be added soon
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. it will be added soon
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional Context

@sang-hee-lee sang-hee-lee added bug Something isn't working enhancement Request Change and Feature Enhancement @dataprep Component Name : Data preparation labels Nov 7, 2018
@sang-hee-lee sang-hee-lee added this to the 3.1.0 milestone Nov 7, 2018
@sang-hee-lee sang-hee-lee self-assigned this Nov 7, 2018
@sang-hee-lee sang-hee-lee requested review from paigechoi, joohokim1 and a team November 7, 2018 04:26
@joohokim1 joohokim1 removed the enhancement Request Change and Feature Enhancement label Nov 7, 2018
@joohokim1 joohokim1 added the testbed3 Review Test Server 3 label Nov 7, 2018
@joohokim1
Copy link
Contributor

run build
deploy to 3

paigechoi
paigechoi previously approved these changes Nov 7, 2018
@joohokim1 joohokim1 removed the testbed3 Review Test Server 3 label Nov 7, 2018
@joohokim1
Copy link
Contributor

run build
deploy to 3

1 similar comment
@joohokim1
Copy link
Contributor

run build
deploy to 3

@joohokim1 joohokim1 added the testbed3 Review Test Server 3 label Nov 7, 2018
@joohokim1
Copy link
Contributor

run build
deploy to 3

1 similar comment
@joohokim1
Copy link
Contributor

run build
deploy to 3

@joohokim1
Copy link
Contributor

run build
deploy to 3

1 similar comment
@joohokim1
Copy link
Contributor

run build
deploy to 3

Copy link
Contributor

@joohokim1 joohokim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.
We need to talk about some details on Staging DB type information, later.

@mh0203 mh0203 self-requested a review November 8, 2018 00:08
@mh0203 mh0203 merged commit e6c34ac into 3.0.6 Nov 8, 2018
@alchan-lee alchan-lee deleted the f#553-different_dataset_information branch November 12, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @dataprep Component Name : Data preparation testbed3 Review Test Server 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants