Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove cookie auth, fix typegraph detection, fix injection, add auth doc, add regression test for doc #327

Merged
merged 9 commits into from
May 30, 2023

Conversation

zifeo
Copy link
Member

@zifeo zifeo commented May 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #327 (275a855) into main (ebb322f) will increase coverage by 0.81%.
The diff coverage is 76.67%.

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   78.81%   79.63%   +0.81%     
==========================================
  Files          64       65       +1     
  Lines        8338     8377      +39     
  Branches      904      926      +22     
==========================================
+ Hits         6572     6671      +99     
+ Misses       1749     1688      -61     
- Partials       17       18       +1     
Impacted Files Coverage Δ
typegate/src/graphql/request_parser.ts 60.49% <0.00%> (-6.18%) ⬇️
typegate/src/auth/auth.ts 59.75% <56.75%> (+23.75%) ⬆️
typegate/src/typegate.ts 54.05% <59.09%> (+3.17%) ⬆️
typegate/src/auth/protocols/protocol.ts 62.50% <62.50%> (ø)
typegate/src/runtimes/random.ts 85.71% <72.50%> (-5.60%) ⬇️
typegate/tests/utils/q.ts 83.92% <72.72%> (-5.30%) ⬇️
typegate/src/auth/protocols/basic.ts 89.13% <78.26%> (+12.53%) ⬆️
typegate/src/auth/protocols/oauth2.ts 85.44% <83.07%> (+4.90%) ⬆️
typegate/src/auth/cookies.ts 93.61% <93.61%> (ø)
typegate/tests/utils.ts 92.80% <94.20%> (+0.05%) ⬆️
... and 5 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@michael-0acf4 michael-0acf4 merged commit f8e5f28 into main May 30, 2023
11 of 12 checks passed
@michael-0acf4 michael-0acf4 deleted the dogfood branch May 30, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants