Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta-test): update t.engine() impl #716

Merged
merged 26 commits into from
May 25, 2024
Merged

feat(meta-test): update t.engine() impl #716

merged 26 commits into from
May 25, 2024

Conversation

destifo
Copy link
Contributor

@destifo destifo commented May 12, 2024

Update the implementation of t.engine()

The change comes with removing the different spin-offs of t.engine which arose from the previous impl of t.engine incompatibility with artifact upload protocol. The change will make t.engine deploy the artifacts in Artifact Resolution mode by running a shell command to deploy the typegraph.

...

MET-500

  • remove different versions of t.engine
  • add tg_deploy caller script which imports typegraphs dynamically and deploys them.
  • make changes to make t.engine run in artifact resolution mode
  • update existing tests to adhere to the current change
  • pass unique different tempDirs to all the typegate instances created during test.
  • add support for authoring multiple typegraphs in a single file in meta-test and add multi typegraph tests.

Migration notes

python SDK test typegraphs' function names should be the same with the filename of the typegraph file, for dynamic import compatibility reasons.

Summary by CodeRabbit

  • New Features

    • Introduced a new function wasm_duplicate to handle WebAssembly runtimes with specific policies.
  • Refactor

    • Renamed and refactored functions and test setups to align with updated test frameworks and improve code clarity.
  • Bug Fixes

    • Added error handling in the getLocalPath function to log warnings if linking errors occur.
  • Tests

    • Updated test scripts to reflect changes in function calls, imports, and engine instantiation for better test accuracy and reliability.

@destifo destifo self-assigned this May 12, 2024
@destifo destifo requested review from Natoandro and Yohe-Am May 13, 2024 20:11
Yohe-Am
Yohe-Am previously approved these changes May 14, 2024
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. That kind of diff is the best kind of diff.

@destifo destifo marked this pull request as ready for review May 15, 2024 08:11
Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

The recent updates in the Typegate project aim to refine test scripts and runtime configurations for WebAssembly and Prisma. Changes involve refactoring test setups, adjusting function signatures, error handling enhancements, and introducing new features for managing WebAssembly runtimes and Prisma settings.

Changes

File(s) Change Summary
typegate/tests/runtimes/wasm_reflected/wasm_sync_test.ts
typegate/tests/runtimes/wasm_wire/wasm_wire.py
typegate/tests/runtimes/wasm_wire/wasm_wire_test.ts
Refactored test scripts by removing unused imports, adjusting function calls, and updating logic for WebAssembly runtimes.
typegate/tests/runtimes/wasm_reflected/wasm_duplicate.py Introduced wasm_duplicate function for managing WebAssembly runtimes and exposing tests with specific policies.
typegate/tests/runtimes/wasm_reflected/wasm_reflected_test.ts Refactored test setup and execution logic for Wasm runtimes.
typegate/src/typegate/artifacts/mod.ts Added error handling with logging for the getLocalPath function.
typegate/tests/runtimes/prisma/normal_1_1.ts, typegate/tests/runtimes/prisma/optional_1_n.ts Modified function declarations to export constants awaiting the result of typegraph.
typegate/tests/utils/test.ts Updated ParseOptions interface, modified methods in MetaTest class, and added a new deployment method.
typegate/tests/utils/tg_deploy_script.py
typegate/tests/utils/tg_deploy_script.ts
Introduced scripts for deploying TypeGraph modules with specified configurations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

typegate/tests/artifacts/artifacts_test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.14%. Comparing base (cca3962) to head (a1118a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   73.40%   73.14%   -0.27%     
==========================================
  Files         121      117       -4     
  Lines       14282    14141     -141     
  Branches     1419     1415       -4     
==========================================
- Hits        10484    10343     -141     
  Misses       3771     3771              
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-0acf4
michael-0acf4 previously approved these changes May 15, 2024
Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 🔥

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 13

typegate/tests/utils/tg_deploy_script.ts Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.ts Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.ts Outdated Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.ts Outdated Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.ts Outdated Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.py Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.py Outdated Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.py Outdated Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.py Outdated Show resolved Hide resolved
typegate/tests/utils/test.ts Show resolved Hide resolved
michael-0acf4
michael-0acf4 previously approved these changes May 16, 2024
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 💪
A few comments...

typegate/tests/artifacts/artifacts_test.ts Outdated Show resolved Hide resolved
typegate/tests/artifacts/artifacts_test.ts Show resolved Hide resolved
typegate/tests/e2e/cli/deploy_test.ts Show resolved Hide resolved
typegate/tests/runtimes/http/http_content_type_test.ts Outdated Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.py Show resolved Hide resolved
typegate/tests/utils/tg_deploy_script.ts Outdated Show resolved Hide resolved
typegate/tests/README.md Outdated Show resolved Hide resolved
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see that cleanup! Still a bunch of comments to take care of and also a lot of any to type a bit better 🙏

typegate/tests/runtimes/prisma/prisma_test.ts Outdated Show resolved Hide resolved
typegate/tests/runtimes/wasm_wire/wasm_wire_test.ts Outdated Show resolved Hide resolved
typegate/tests/e2e/cli/deploy_test.ts Outdated Show resolved Hide resolved
typegate/tests/utils/test.ts Outdated Show resolved Hide resolved
Yohe-Am
Yohe-Am previously approved these changes May 24, 2024
@Yohe-Am Yohe-Am requested a review from zifeo May 24, 2024 18:25
zifeo
zifeo previously approved these changes May 25, 2024
typegate/tests/README.md Outdated Show resolved Hide resolved
@destifo destifo dismissed stale reviews from zifeo and Yohe-Am via a1118a0 May 25, 2024 17:14
@destifo destifo merged commit f951bd1 into main May 25, 2024
14 checks passed
@destifo destifo deleted the meta-test/engine branch May 25, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants