-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta-test): update t.engine()
impl
#716
Conversation
…o tg push and tg_deploy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. That kind of diff is the best kind of diff.
WalkthroughThe recent updates in the Typegate project aim to refine test scripts and runtime configurations for WebAssembly and Prisma. Changes involve refactoring test setups, adjusting function signatures, error handling enhancements, and introducing new features for managing WebAssembly runtimes and Prisma settings. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 73.40% 73.14% -0.27%
==========================================
Files 121 117 -4
Lines 14282 14141 -141
Branches 1419 1415 -4
==========================================
- Hits 10484 10343 -141
Misses 3771 3771
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 🔥
…d more artifact upload tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 💪
A few comments...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool to see that cleanup! Still a bunch of comments to take care of and also a lot of any to type a bit better 🙏
…eta-test/engine
…eta-test/engine
Update the implementation of
t.engine()
The change comes with removing the different spin-offs of
t.engine
which arose from the previous impl of t.engine incompatibility with artifact upload protocol. The change will maket.engine
deploy the artifacts in Artifact Resolution mode by running a shell command to deploy the typegraph....
MET-500
t.engine
t.engine
run in artifact resolution modetempDir
s to all the typegate instances created during test.meta-test
and add multi typegraph tests.Migration notes
python SDK test typegraphs' function names should be the same with the filename of the typegraph file, for dynamic import compatibility reasons.
Summary by CodeRabbit
New Features
wasm_duplicate
to handle WebAssembly runtimes with specific policies.Refactor
Bug Fixes
getLocalPath
function to log warnings if linking errors occur.Tests