Refactor vue-coffee #243
Merged
Refactor vue-coffee #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than a fork of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See meteor/meteor#8960 / meteor/meteor#9018
This PR refactors the
vue-coffeepackage to use the new Meteorcoffeescript-compilerpackage, which is the “compilation” part of the old Meteorcoffeescriptpackage split apart from the “build compiler plugin” part.vue-coffeeusingcoffeescript-compilerletsvue-coffeeavoid needing to fork the old Meteorcoffeescriptpackage, and letsvue-coffeeshrink down to just a few lines of code. This also positionsvue-coffeeto easily respond to new upstream versions ofcoffeescript-compiler(most likely by bumping a dependency version number, with no other changes).