Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01-creating-app.md #13

Closed
wants to merge 1 commit into from

Conversation

nguyentichduy123
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@filipenevola
Copy link
Collaborator

Hey @nguyentichduy123, could you sign the CLA?

Thanks.

@denihs
Copy link
Contributor

denihs commented Apr 15, 2021

Hi @nguyentichduy123, thank you for your PR.

Just to give you context, it is supposed to be .app. as it is right now, but I get why you suggested the changes, the thing is, we already had this PR to fix those mistakes in the tutorial and I just merge it.

We are using .app. from now on, instead of .body. because in order to the new hot-module-replacement package work, all the templates must have a name, and the body is anonymous.

I will close this PR. If you have questions, let me know.

@denihs denihs closed this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants