Test plugin improvements #46
Conversation
This commit introduces the following changes to the `cordova-plugin-meteor-webapp-tests` (`/tests`) plugin: - Fix Swift compilation errors preventing the iOS tests from running. - Add a `package.json` so the test plugin can be added as a separate plugin with modern versions of Cordova. - Adjust the tests `after_plugin_install` call to reference the `iosAddBridgingHeader.js` helper file as if it was part of the `cordova-plugin-meteor-webapp-tests` plugin. Otherwise the `iosAddBridgingHeader.js` file can't be found when `cordova-plugin-meteor-webapp-tests` is added via `cordova plugin add`.
|
Thanks very much for looking at this. I mostly support the type of Swift changes you've made here, even if I don't understand when exactly they became required. I'm curious if the test suite passes more successfully if the |
|
Great question @abernix - I'll test things out and post back shortly. |
When the `cordova-plugin-meteor-webapp-tests` plugin is installed, it ends up in an apps `plugins` directory, at the same level as the `cordova-plugin-meteor-webapp` plugin. This commit updates the path the tests use to find the shared `scripts` directory (which is in the `cordova-plugin-meteor-webapp` plugin) when installed.
|
I think getting these tests running again is likely highly beneficial, so I've merged this. I should have a follow-up PR soon which will help run these tests automatically, rather than needing to follow all the steps in this new I did encounter a problem with this PR when I first tried it but it was fixed when @hwillson added the second commit (a7d4868). That commit is also proving to be important when trying to run the tests when the repository was in an older state, so I'm maintaining it upon merging this, and not squashing it out. Thanks again for working on this! |
By using TravisCI's Mac testing environment, which comes fully-equipped with Xcode and iOS simulators, we can run the test suite which @hwillson revived in #46, automatically. While many of the tests are failing, there are some passing, which seems to prove that the testing framework is functioning properly, though doesn't provide much assurance that we'll be able to fix the tests (though it's likely, and I'm hopeful, that we can!). Despite hesitance to do so, I've specifically pinned the iOS simulator to use iOS 11.2 since the `cordova-paramedic` npm tries to obtain the logs from the simulator by looking through the output of `instruments -s devices`, though the `cordova` npm is only aware of minor versions in iOS releases, not patch versions (e.g 11.0.1, which it classifies as 11.0). Since Travis is automatically updating to patch versions of iOS, presumably in an effort to solve the security problems or deficiencies the initial releases had, this seems necessary for the time being. Anyone should bump the simulator OS version as necessary/beneficial. We could potentially fix this in our own fix to `cordova-paramedic`, which I've already had to fork for unrelated reasons, but I haven't taken the time to investigate whether this is reasonable. This also adds `ios-deploy` and `ios-sim` as `devDependencies` for testing, and removes them from their previous installation location in `.travis.yml`, which makes it possible to run `npm test` locally.
While prepping an answer for issue #8, I took a quick look at the current
cordova-plugin-meteor-webapptesting approach. Unless I'm missing something (which is entirely possible!) it looks like the current tests haven't been run in quite some time, as the iOS tests specifically can't be run due to Swift compilation errors.To help with this, this PR addresses the following
cordova-plugin-meteor-webapp/cordova-plugin-meteor-webapp-testsissues:package.jsonso the test plugin can be added as a separate plugin with modern versions of Cordova.after_plugin_installcall to reference theiosAddBridgingHeader.jshelper file as if it was part of thecordova-plugin-meteor-webapp-testsplugin. Otherwise theiosAddBridgingHeader.jsfile can't be found whencordova-plugin-meteor-webapp-testsis added viacordova plugin add.This PR also includes a new
DEVELOPMENT.mdfile that contains detailed instructions outlining an approach for running thecordova-plugin-meteor-webapp-testsiOS tests (using local checkouts to make debugging easier).The above being said, this PR does NOT address the failing iOS tests (38 out of 69 iOS tests are failing). It just adjusts the testing infrastructure so we can at least see the failing tests. I'll look into addressing the failing tests in a separate PR.
Fixes #8.
Thanks!