Fix handling updates to dynamic imports with HMR

meteor · Oct 15, 2020 · 79529f5 · 79529f5
1 parent 7b535de
commit 79529f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/dynamic-import/package.js b/packages/dynamic-import/package.js
@@ -14,6 +14,7 @@ Package.onUse(function (api) {
   api.use("fetch");
   api.use("modern-browsers");
   api.use("inter-process-messaging", "server");
+  api.use("hot-module-replacement", { weak: true });
 
   api.mainModule("client.js", "client");
   api.mainModule("server.js", "server");

diff --git a/tools/isobuild/bundler.js b/tools/isobuild/bundler.js
@@ -1281,10 +1281,7 @@ class Target {
             data: resource.data,
             hash: resource.hash,
             cacheable: false,
-            // Temporarily override for the dynamic-import package
-            // to allow updating with HMR the modules that are 
-            // dynamically imported
-            replaceable: resource.type === 'js' && (sourceBatch.hmrAvailable || name === 'dynamic-import')
+            replaceable: resource.type === 'js' && sourceBatch.hmrAvailable
           });
 
           const relPath = stripLeadingSlash(resource.servePath);