Skip to content

Commit

Permalink
Remove the 'sass' package, as warned in 0.5.0.
Browse files Browse the repository at this point in the history
Meteor's sass package wraps the "sass" NPM module, which implements a version of
the Sass language much older than the .sass described at sass-lang.com (and
doesn't implement the current recommended .scss language at all). It also has
poor error handling, so it mostly just ends up confusing users.

The module is unmaintained, and its author now uses stylus/nib (which Meteor
supports: see the stylus package).

If many users want Sass support, we could add this back in wrapping the
"node-sass" package instead (which supports a more recent version of the Sass
language), but for now, just remove it. Meteor still supports Stylus and Less
out of the box.

Fixes #143.
  • Loading branch information
glasser committed Nov 5, 2012
1 parent c8a9bc9 commit a5cc93e
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 85 deletions.
7 changes: 0 additions & 7 deletions LICENSE.txt
Expand Up @@ -156,13 +156,6 @@ stylus: https://github.com/learnboost/stylus
Copyright (c) 2010 LearnBoost <dev@learnboost.com>


----------
sass: https://github.com/visionmedia/sass.js
----------

Copyright (c) 2009 TJ Holowaychuk <tj@vision-media.ca>


----------
jquery-waypoints: https://github.com/imakewebthings/jquery-waypoints
----------
Expand Down
1 change: 0 additions & 1 deletion admin/generate-dev-bundle.sh
Expand Up @@ -78,7 +78,6 @@ npm install gzippo@0.1.7
npm install optimist@0.3.4
npm install coffee-script@1.3.3
npm install less@1.3.0
npm install sass@0.5.0
npm install stylus@0.29.0
npm install nib@0.8.2
npm install mime@1.2.7
Expand Down
1 change: 0 additions & 1 deletion docs/client/docs.js
Expand Up @@ -274,7 +274,6 @@ var toc = [
"force-ssl",
"jquery",
"less",
"sass",
"spiderable",
"stylus",
"showdown",
Expand Down
1 change: 0 additions & 1 deletion docs/client/packages.html
Expand Up @@ -25,7 +25,6 @@ <h1 id="packages">Packages</h1>
{{> pkg_force_ssl}}
{{> pkg_jquery}}
{{> pkg_less}}
{{> pkg_sass}}
{{> pkg_spiderable}}
{{> pkg_stylus}}
{{> pkg_showdown}}
Expand Down
21 changes: 0 additions & 21 deletions docs/client/packages/sass.html

This file was deleted.

33 changes: 0 additions & 33 deletions packages/sass/package.js

This file was deleted.

14 changes: 0 additions & 14 deletions packages/sass/sass_tests.js

This file was deleted.

7 changes: 0 additions & 7 deletions packages/sass/sass_tests.sass

This file was deleted.

0 comments on commit a5cc93e

Please sign in to comment.