Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node 8.12 to address CPU usage problems related to fibers #10117

Closed
jimrandomh opened this issue Aug 1, 2018 · 5 comments
Closed

Upgrade to Node 8.12 to address CPU usage problems related to fibers #10117

jimrandomh opened this issue Aug 1, 2018 · 5 comments
Milestone
Release 1.8.1

Comments

@jimrandomh
Copy link

Node has a bug fix related to performance with fibers, which is very important to Meteor. Without the fix applied, any Meteor process which creates a large number of fibers will become very slow; switching between fibers is O(n) in the peak number of concurrent fibers the process has ever contained.

The fix is present in Node 10.2.0 and later, and which will be in Node 8.12 as soon as they cut a release, which should be soon. Meteor is currently on Node 8.11, which is affected.

Node 8.12 release PR page: nodejs/node#21593
@jimrandomh jimrandomh mentioned this issue Aug 1, 2018
Open
@harrisonhunter
Copy link

This should be handled in this PR: #10090 which looks like it should land in 1.7.1

@macrozone
Copy link
Contributor

node 8.12 has been released! https://nodejs.org/en/blog/release/v8.12.0/

@benjamn
Copy link
Contributor

benjamn commented Sep 11, 2018

You can start using Node 8.12.0 in the latest Meteor 1.7.1 release candidates!

meteor update --release 1.7.1-rc.11

@benjamn benjamn closed this as completed Sep 11, 2018
@benjamn benjamn added this to the Release 1.7.1 milestone Sep 11, 2018
@macrozone macrozone mentioned this issue Sep 13, 2018
Closed
@benjamn benjamn reopened this Sep 13, 2018
@benjamn
Copy link
Contributor

benjamn commented Sep 18, 2018

See also #10216, which is why we've reverted the upgrade for now.

@benjamn benjamn modified the milestones: Release 1.8, Release 1.8.1 Oct 6, 2018
benjamn added a commit that referenced this issue Oct 6, 2018
@benjamn
Update Node.js to version 8.12.0.
f16e760 
https://nodejs.org/en/blog/release/v8.12.0/

Closes #10117 and #10090.

We will continue to monitor issue #10216.
@promentol promentol mentioned this issue Oct 30, 2018
Open
@benjamn
Copy link
Contributor

benjamn commented Dec 7, 2018

In order to reflect what's been fixed in the Meteor 1.8.1 milestone so far, I'm going to close this issue now, though of course you'll need to run

meteor update --release 1.8.1-beta.8

to get Node 8.14.0.

@benjamn benjamn closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8.1
Development

No branches or pull requests
4 participants
@benjamn @jimrandomh @macrozone @harrisonhunter