Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.1-beta.3] Exception while invoking method 'login'; TypeError: DiffSequence.diffMaps is not a function #10320

Closed
rj-david opened this issue Nov 4, 2018 · 9 comments
Assignees
Labels
confirmed We want to fix or implement it Project:DDP Type:Bug

Comments

@rj-david
Copy link
Contributor

rj-david commented Nov 4, 2018

Version showing the problem: 1.8.1-beta.3
Last version without problem: 1.8.1-beta.2

Stack trace

===== message ===== Exception while invoking method 'login'
===== stack ===== TypeError: DiffSequence.diffMaps is not a function
    at Session._diffCollectionViews (packages/ddp-server/livedata_server.js:762:18)
    at packages/ddp-server/livedata_server.js:842:12
    at Object.Meteor._noYieldsAllowed (packages/meteor.js:848:12)
    at Session._setUserId (packages/ddp-server/livedata_server.js:840:12)
    at MethodInvocation.setUserId [as _setUserId] (packages/ddp-server/livedata_server.js:677:14)
    at MethodInvocation.setUserId (packages/ddp-common/method_invocation.js:92:10)
    at AccountsServer._loginUser (packages/accounts-base/accounts_server.js:287:22)
    at AccountsServer._attemptLogin (packages/accounts-base/accounts_server.js:342:17)
    at MethodInvocation.methods.login (packages/accounts-base/accounts_server.js:520:23)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12)
    at DDP._CurrentMethodInvocation.withValue (packages/ddp-server/livedata_server.js:719:19)
    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1304:12)
    at DDPServer._CurrentWriteFence.withValue (packages/ddp-server/livedata_server.js:717:46)
    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1304:12)
    at Promise (packages/ddp-server/livedata_server.js:715:46)
    at new Promise (<anonymous>)
(node:20075) UnhandledPromiseRejectionWarning: TypeError: CreateListFromArrayLike called on non-object
    at Object._debug (imports/startup/server/error.js:37:32)
    at wrapInternalException (packages/ddp-server/livedata_server.js:1741:12)
    at promise.then.exception (packages/ddp-server/livedata_server.js:745:25)
    at /home/rj/.meteor/packages/promise/.0.11.1.ihl06c.0g81b++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
(node:20075) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
(node:20075) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Reproduction:
https://github.com/rj-david/meteor-issue-10320

@klaussner klaussner added Project:DDP needs-reproduction We can't reproduce so it's blocked labels Nov 4, 2018
@klaussner
Copy link
Contributor

Could you please provide a reproduction (see Reporting a bug in Meteor)?

@rj-david
Copy link
Contributor Author

rj-david commented Nov 4, 2018

Here is the reproduction: https://github.com/rj-david/meteor-issue-10320

@klaussner klaussner added confirmed We want to fix or implement it Type:Bug and removed needs-reproduction We can't reproduce so it's blocked labels Nov 4, 2018
@klaussner
Copy link
Contributor

Thanks, @rj-david. This issue could be related to the changes I made in #10238. However, the login works if I run your reproduction with a devel checkout of Meteor (903bdea). 🤔

@rj-david
Copy link
Contributor Author

rj-david commented Nov 4, 2018

@klaussner, I checked out that commit and got the same error

I also checked out the HEAD of devel and also got the same error

@rj-david
Copy link
Contributor Author

rj-david commented Nov 4, 2018

Ok, I might be running it wrong. I have meteor checked out on the same folder level as my reproduction. Is it right that I executed my reproduction using the following:

../meteor/meteor npm run start

Other things that I need to consider to ensure that I am running from the checked out code instead of the installed meteor?

[Erratum]
The script above still calls the installed meteor

@klaussner
Copy link
Contributor

I think that's right, but I just tried it again and it works with my Meteor checkout: https://streamable.com/6icep.

@Antoine-O
Copy link

My stacktrace if it helps :

Exception while invoking method 'login' TypeError: DiffSequence.diffMaps is not a function
    at Session._diffCollectionViews (packages/ddp-server/livedata_server.js:762:18)
    at packages/ddp-server/livedata_server.js:842:12
    at Object.Meteor._noYieldsAllowed (packages\meteor.js:848:12)
    at Session._setUserId (packages/ddp-server/livedata_server.js:840:12)
    at MethodInvocation.setUserId [as _setUserId] (packages/ddp-server/livedata_server.js:677:14)
    at MethodInvocation.setUserId (packages/ddp-common/method_invocation.js:92:10)
    at AccountsServer._loginUser (packages/accounts-base/accounts_server.js:287:22)
    at AccountsServer._attemptLogin (packages/accounts-base/accounts_server.js:342:17)
    at MethodInvocation.methods.login (packages/accounts-base/accounts_server.js:520:23)
    at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1771:12)
    at DDP._CurrentMethodInvocation.withValue (packages/ddp-server/livedata_server.js:719:19)
    at Meteor.EnvironmentVariable.EVp.withValue (packages\meteor.js:1304:12)
    at DDPServer._CurrentWriteFence.withValue (packages/ddp-server/livedata_server.js:717:46)
    at Meteor.EnvironmentVariable.EVp.withValue (packages\meteor.js:1304:12)
    at Promise (packages/ddp-server/livedata_server.js:715:46)
    at new Promise (<anonymous>)

@rj-david
Copy link
Contributor Author

rj-david commented Nov 6, 2018

Thanks, @Antoine-O.

@klaussner, running the npm script called the installed meteor. Sorry, my fault.

I can confirm that the tagged beta.3 is running without problems. There might be a problem when creating the build for download. Any suggestion how can we go on figuring this out?

@Antoine-O
Copy link

I have this issue in dev (windows) and production (docker with linux), rollback to beta.2 fixed it. Waiting for beta 4 ;)

benjamn added a commit that referenced this issue Nov 13, 2018
After @nathan-muir's PR #10053, we did not publish a new version of the
diff-sequence package, which would have contained DiffSequence.diffMaps.

I honestly have no idea why #10320 did not manifest before now, but
publishing these changes seems to fix it.
@benjamn benjamn added this to the Package Patches milestone Nov 13, 2018
@benjamn benjamn self-assigned this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it Project:DDP Type:Bug
Projects
None yet
Development

No branches or pull requests

4 participants