Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linker] Does the json package need to export JSON? #1204

Closed
awwx opened this issue Jul 3, 2013 · 1 comment
Closed

[linker] Does the json package need to export JSON? #1204

awwx opened this issue Jul 3, 2013 · 1 comment

Comments

@awwx
Copy link
Contributor

awwx commented Jul 3, 2013

meteor/packages/json/json2.js

Line 163 in 12a9361

JSON = {};

I'm guessing you either want to inject it into the global environment (this.JSON = {}) or export it, but right now it looks like JSON is package-scoped.
@raix
Copy link
Contributor

raix commented Jul 24, 2013

👍
@awwx or only load if needed - feature detection, an old topic

glasser added a commit that referenced this issue Aug 2, 2013
@glasser
Export JSON from json package.
e712d78 
Make sure to use the built-in JSON if it exists.

Fixes #1204.
@glasser glasser closed this as completed Aug 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glasser @awwx @raix