Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow us to access the extra parameters passed along with jquery event #1988

Merged
merged 2 commits into from
Apr 11, 2014

Conversation

apendua
Copy link
Contributor

@apendua apendua commented Mar 31, 2014

Just re-opening an automatically closed PR #1966, as @Slava asked me to do so. The issue was already mentioned here #1793. Here is a very simple (and probably harmless) fix.

@glasser glasser added the Blaze label Apr 4, 2014
@avital
Copy link
Contributor

avital commented Apr 10, 2014

Please add a test (see packages/spacebars-tests for examples). You should verify that the test fails before your change and passes afterwards.

@apendua
Copy link
Contributor Author

apendua commented Apr 11, 2014

@avital I added a test. Hope this will work fine.

avital added a commit that referenced this pull request Apr 11, 2014
Expose extra parameters in custom jQuery events
@avital avital merged commit e7a85a3 into meteor:devel Apr 11, 2014
@avital
Copy link
Contributor

avital commented Apr 11, 2014

Thanks, merged!

martijnwalraven pushed a commit that referenced this pull request Feb 22, 2016
Expose extra parameters in custom jQuery events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed We want to fix or implement it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants