Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update d3 lib #2557

Closed
dnprock opened this issue Sep 9, 2014 · 12 comments
Closed

Update d3 lib #2557

dnprock opened this issue Sep 9, 2014 · 12 comments

Comments

@dnprock
Copy link

dnprock commented Sep 9, 2014

Can you update current d3 lib? Current version is 3.1.4 and latest version is 3.4.11. We ran into several bugs in 3.1.4.

@tejasmanohar
Copy link

@dnprock is this a lib by the core team? If not, might want to make an issue with the actual repo.

@mizzao
Copy link
Contributor

mizzao commented Sep 10, 2014

It is a core library, but it's probably time to start migrating wrapper libraries like d3 out of core.

You can always publish your own.

@tejasmanohar
Copy link

Odd that's in the core, but sorry for speaking without complete understanding.

@glasser
Copy link
Contributor

glasser commented Sep 10, 2014

Agreed. If nobody beats me to it, I will probably start migrating the wrapper libraries out of core after my upcoming vacation (ie in October).

External libraries like d3 aren't a good fit for being in core; doing the upgrade now will mean that everyone upgrading Meteor will be forced to upgrade d3 and vice versa. So this might wait until then.

@ephemer
Copy link

ephemer commented Sep 15, 2014

I also vote to have bootstrap taken out of the core. Especially given that it's bootstrap 2, which is over a year old now.

@dnprock
Copy link
Author

dnprock commented Sep 17, 2014

Yes, should move it outside core.

@dandv
Copy link
Contributor

dandv commented Nov 21, 2014

d3 is being migrated - #3082

@awatson1978
Copy link
Contributor

Will this migration include coffeescript and less? Because they're really just wrapper packages too.

Some of us think there's much to be done with D3 and it should remain part of core. Meteor needs an officially supported graphing library and a data analytics pipeline; particularly if it's going to be adopted by corporate america. I'd be happy to contribute such code. But getting rid of D3 is a bad idea.

@emgee3
Copy link
Contributor

emgee3 commented Nov 21, 2014

The less and coffeescript packages have both contain their own specific source handlers, thus there is some Meteor-specific integration. It's not really the same thing as the d3 package, which simply and only dropped the d3.js file into client.

That's not to say it's not useful to have a d3 package — it is, so you can ensure load order, use it as a dependency, keep it up to date and pin to a specific version. But MDG stewardship of the d3 package was lacking and you're better off using your own wrapper.

@dandv
Copy link
Contributor

dandv commented Nov 24, 2014

@awatson1978: another avenue is getting official integration straight from d3.
I've started an effort to add official Meteor support to popular libraries.

@awatson1978
Copy link
Contributor

More likely, I'll wind up supporting the integration myself through the Clinical Meteor Track. I have enough other things on my plate, that it would be really nice to have the support and resources of the core team with D3. But it sounds like maybe it's myself who needs to be supporting others. I've got an entire realtime analytics pipeline using service workers, aggregation, D3 and NVD3 that's ready to be broken up into packages and published. Just need to find the time. :sigh:

@dandv
Copy link
Contributor

dandv commented Nov 25, 2014

I've submitted a PR to @mbostock for official d3 <-> Meteor integration.

Please log into Atmosphere with your MD account and,

This issue can now be closed. Thanks!

@glasser glasser closed this as completed Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants