-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update d3 lib #2557
Comments
@dnprock is this a lib by the core team? If not, might want to make an issue with the actual repo. |
It is a core library, but it's probably time to start migrating wrapper libraries like d3 out of core. You can always publish your own. |
Odd that's in the core, but sorry for speaking without complete understanding. |
Agreed. If nobody beats me to it, I will probably start migrating the wrapper libraries out of core after my upcoming vacation (ie in October). External libraries like d3 aren't a good fit for being in core; doing the upgrade now will mean that everyone upgrading Meteor will be forced to upgrade d3 and vice versa. So this might wait until then. |
I also vote to have bootstrap taken out of the core. Especially given that it's bootstrap 2, which is over a year old now. |
Yes, should move it outside core. |
d3 is being migrated - #3082 |
Will this migration include coffeescript and less? Because they're really just wrapper packages too. Some of us think there's much to be done with D3 and it should remain part of core. Meteor needs an officially supported graphing library and a data analytics pipeline; particularly if it's going to be adopted by corporate america. I'd be happy to contribute such code. But getting rid of D3 is a bad idea. |
The less and coffeescript packages have both contain their own specific source handlers, thus there is some Meteor-specific integration. It's not really the same thing as the d3 package, which simply and only dropped the d3.js file into client. That's not to say it's not useful to have a d3 package — it is, so you can ensure load order, use it as a dependency, keep it up to date and pin to a specific version. But MDG stewardship of the d3 package was lacking and you're better off using your own wrapper. |
@awatson1978: another avenue is getting official integration straight from d3. |
More likely, I'll wind up supporting the integration myself through the Clinical Meteor Track. I have enough other things on my plate, that it would be really nice to have the support and resources of the core team with D3. But it sounds like maybe it's myself who needs to be supporting others. I've got an entire realtime analytics pipeline using service workers, aggregation, D3 and NVD3 that's ready to be broken up into packages and published. Just need to find the time. :sigh: |
I've submitted a PR to @mbostock for official d3 <-> Meteor integration. Please log into Atmosphere with your MD account and, This issue can now be closed. Thanks! |
Can you update current d3 lib? Current version is 3.1.4 and latest version is 3.4.11. We ran into several bugs in 3.1.4.
The text was updated successfully, but these errors were encountered: