Spark crash on select attribute typo

[jpmx]

Ex. <select name="pick" class"typo">

Tested with
Meteor 0.5.2 & devel
Mac Chrome Version 23.0.1271.91

Reproduction recipe:

git clone git://github.com/jpea/spark-patch-bug.git

And watch console

[glasser]

Can you check with the spark-original-value branch too?
On Nov 27, 2012 11:48 PM, "JP Espinosa" notifications@github.com wrote:

Ex. <select name="pick" class"typo">

Tested with
Meteor 0.5.2 & devel
Mac Chrome Version 23.0.1271.91

Reproduction recipe:

git clone git://github.com/jpea/spark-patch-bug.git

And watch console

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/512.

[jpmx]

Yep, the bug is still on spark-original-value branch

[glasser]

I can reproduce this, thanks. In _copyAttributes, tgt.setAttribute(name, value) gets called with name 'class"typo"' and value ''.

I'm not really sure what to do, though. The developer had an error, and there's an exception thrown. I can try to catch the error, but then what? I'm not sure how cross-browser compatible this particular error message is, and should we just mask the error (so the developer won't notice their typo), or what?

The only real change I think is worth making in response to this error is catching and re-throwing the error in a new Error that explicitly includes the attribute name. Does that seem reasonable?

[jpmx]

Totally reasonable, that would have saved hours of debugging other pieces of my code

Thanks!, and keep the great work :)