You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
buildmessage does support the idea of tagged messages, but the entire system seems to be built around the idea that a message is always an error. Here are some changes that could improve the situation:
Make buildmessage.error tag the added message as an "error"
Make a method MessageSet#hasErrors that checks this tag only (along with Job#hasErrors) and use this everywhere hasMessages is used now (since until now it always checked for errors
Add buildmessage.warning which tags as "warning"
Add hasWarnings like hasErrors above
Modify the places that print build message errors to also know how to print warnings
Add some build warnings around deprecated build plugin APIs, so that people update their code eventually
For now, I'm going to just remove the error and have the old API silently succeed, so that people don't need a ton of if statements in their package.js files.
The text was updated successfully, but these errors were encountered:
Public Service Announcement: Even if not terribly in demand, this would be a good PR for someone looking to contribute to Meteor. It's well outlined, and reasonable for a first-timer.
(Bullet point 6 can be a separate issue which is dependent on this, but a bonus if you want to use the new feature for what it was needed for!)
To help provide a more clear separation between feature requests and bugs, and to help clean up the feature request backlog, Meteor feature requests are now being managed under the https://github.com/meteor/meteor-feature-requests repository.
This feature request will be closed here, but anyone interested in migrating this feature request to the new repository (to make sure it stays active), can click here to start the feature request migration process. This manual migration process is intended to help identify which of the older feature requests are still considered to be of value to the community. Thanks!
I'm trying to convert the error I added in
1.2
aboutapi.addFiles
with theisAsset
option into a warning, but there isn't a reasonable way to do it.The issue about that is #5458
buildmessage
does support the idea of tagged messages, but the entire system seems to be built around the idea that a message is always an error. Here are some changes that could improve the situation:buildmessage.error
tag the added message as an"error"
MessageSet#hasErrors
that checks this tag only (along withJob#hasErrors
) and use this everywherehasMessages
is used now (since until now it always checked for errorsbuildmessage.warning
which tags as"warning"
hasWarnings
likehasErrors
aboveFor now, I'm going to just remove the error and have the old API silently succeed, so that people don't need a ton of if statements in their
package.js
files.The text was updated successfully, but these errors were encountered: