Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a principled way to print warnings from the Meteor build tool #5495

Closed
stubailo opened this issue Oct 21, 2015 · 2 comments
Closed

Add a principled way to print warnings from the Meteor build tool #5495

stubailo opened this issue Oct 21, 2015 · 2 comments

Comments

@stubailo
Copy link
Contributor

I'm trying to convert the error I added in 1.2 about api.addFiles with the isAsset option into a warning, but there isn't a reasonable way to do it.

The issue about that is #5458

buildmessage does support the idea of tagged messages, but the entire system seems to be built around the idea that a message is always an error. Here are some changes that could improve the situation:

  1. Make buildmessage.error tag the added message as an "error"
  2. Make a method MessageSet#hasErrors that checks this tag only (along with Job#hasErrors) and use this everywhere hasMessages is used now (since until now it always checked for errors
  3. Add buildmessage.warning which tags as "warning"
  4. Add hasWarnings like hasErrors above
  5. Modify the places that print build message errors to also know how to print warnings
  6. Add some build warnings around deprecated build plugin APIs, so that people update their code eventually

For now, I'm going to just remove the error and have the old API silently succeed, so that people don't need a ton of if statements in their package.js files.

@abernix
Copy link
Contributor

abernix commented Oct 28, 2016

Public Service Announcement: Even if not terribly in demand, this would be a good PR for someone looking to contribute to Meteor. It's well outlined, and reasonable for a first-timer.

(Bullet point 6 can be a separate issue which is dependent on this, but a bonus if you want to use the new feature for what it was needed for!)

@hwillson
Copy link
Contributor

hwillson commented Jun 9, 2017

To help provide a more clear separation between feature requests and bugs, and to help clean up the feature request backlog, Meteor feature requests are now being managed under the https://github.com/meteor/meteor-feature-requests repository.

This feature request will be closed here, but anyone interested in migrating this feature request to the new repository (to make sure it stays active), can click here to start the feature request migration process. This manual migration process is intended to help identify which of the older feature requests are still considered to be of value to the community. Thanks!

@hwillson hwillson closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants