Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteor 1.5-rc.10 on Internet Explorer 11: can't redefine non-configurable property __esModule #8724

Closed
macrozone opened this issue May 29, 2017 · 11 comments
Assignees
Labels
in-development We are already working on it
Milestone

Comments

@macrozone
Copy link
Contributor

I have updated an app to 1.5-rc.10 and i get a client error on internet explorer:

SCRIPT5078: Die nicht konfigurierbare Eigenschaft "__esModule" kann nicht neu definiert werden

(should be in english: can't redefine non-configurable property __esModule)

it happens on this line:

import { useDeps, composeAll, composeWithTracker, compose } from 'mantra-core';

@macrozone
Copy link
Contributor Author

macrozone commented May 29, 2017

ok, happens when .babelrc contains the preset "es2015" or "env"

By the way, what are the recomended .babelrc settings for meteor?

@benjamn
Copy link
Contributor

benjamn commented May 29, 2017

I believe this will be fixed once 1.5-rc.11 is available (currently publishing).

By the way, what are the recomended .babelrc settings for meteor?

Our hope is that you shouldn't need a .babelrc file at all, but I would specifically caution you that babel-preset-es2015 and babel-preset-env are likely to overlap significantly with babel-preset-meteor, which is always included.

@benjamn benjamn added this to the Release 1.5 milestone May 29, 2017
@benjamn benjamn self-assigned this May 29, 2017
@benjamn benjamn added in-development We are already working on it known-fix labels May 29, 2017
@macrozone
Copy link
Contributor Author

macrozone commented May 29, 2017

@benjamn thx, will check if it works.

I think my other reported issues are all because of babel-preset-es2015. I will verify that

edit: I need the 2015 preset for react-storybooks and storyshots

@benjamn
Copy link
Contributor

benjamn commented May 31, 2017

No rush, but please close this issue whenever you can confirm it's fixed in Meteor 1.5.

@jonasblumer
Copy link

jonasblumer commented Jun 6, 2017

@benjamn I'm having the same issue (with meteor 1.5, same error message in ie11)
also doesn't work when using babel-preset-meteor. i get the following error when running storyshots

=> Loading custom .babelrc evalmachine.<anonymous>:1 (function (exports, require, module, __filename, __dirname) { import { configure, setAddon, addDecorator } from '@kadira/storybook'; ^^^^^^ SyntaxError: Unexpected token import

@pozylon
Copy link

pozylon commented Jun 9, 2017

Hi there, same here. Argh IE11 !!!

@macrozone
Copy link
Contributor Author

here is the fix when using storybook:

do not use es2015 for root .babelrc as @benjamn stated.

Add an additional .babelrc inside .storybook folder:

{
  "extends": "../.babelrc",
  "presets": ["es2015", "stage-2", "react"]
}

@ffxsam
Copy link
Contributor

ffxsam commented Jun 10, 2017

I believe this is what's causing my app to not work at all on IE11. It's making Flow Router choke, and none of my routes work. This is with Meteor 1.5.

@ffxsam
Copy link
Contributor

ffxsam commented Jun 11, 2017

Disregard. Rolled back to Meteor 1.4.x, and I'm still getting the "There is no route for the path: /xyz/abc" error in IE11. I don't get any other details, so this one seems pretty tough to debug. 😢

@skirunman
Copy link
Contributor

Can this be closed?

@abernix abernix modified the milestones: Release 1.5.2, Release 1.5 Sep 7, 2017
@hwillson
Copy link
Contributor

Sounds like this has been resolved. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-development We are already working on it
Projects
None yet
Development

No branches or pull requests

8 participants