Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Support For Ipad Pro (Launch Storyboard Images) #9240

Closed
andyrichardson opened this issue Oct 17, 2017 · 6 comments
Closed

No Support For Ipad Pro (Launch Storyboard Images) #9240

andyrichardson opened this issue Oct 17, 2017 · 6 comments

Comments

@andyrichardson
Copy link

Description
Meteor apps do not run in native resolution on Ipad Pro (12.6 inch, 1st gen).

Effected versions
1.5.2 (current) and older

Cause
No support for storyboard images in mobile-conifg.js.

Proposed solution
Add storyboard support to mobile-config.js

// mobile-config.js

App.launchScreens({
  default_2x_universal_anyany: "resources/splashscreens/Default@2x~universal~anyany.png",
  default_3x_ipad_comany: "resources/splashscreens/Default@3x~ipadl~comany.png",
  ...
});

Resources
See bug description and Cordova documentation.

@hwillson
Copy link
Contributor

@andyrichardson This was addressed in #9198, and has been merged. These changes will likely be coming in 1.5.3. Thanks!

@skirunman
Copy link
Contributor

@hwillson We may want to re-open this issue as the changes I made in #9198 for iPad Pro 10.5" and 12.9" were removed in 0ab3277 as Apple / Xcode 9, and therefore cordova-ios, does not support using static images for these splash screen sizes.

Instead Apple and Cordova recommends using Launch Storyboards. We can add this support to a Meteor Cordova app today in mobile-config.js like

App.appendToConfig(`
  <splash src="../../../resources/splash/ios/Default@3x~universal~anyany.png" />
`);

I'm not sure if we should make changes to our parsing of mobile-config.js to support this or just update the documentation. In any case you can see where cordova-ios supports this here.

@hwillson
Copy link
Contributor

Thanks @skirunman - I think documenting this for now is our best bet. I've opened meteor/guide#675 to track this, so we can keep this issue closed. Thanks again!

@markshust
Copy link

This ticket should probably be reopened. Xcode is replacing all app launch screens with storyboards in Xcode 11 and moving forward, and there is currently no support in storyboard images in Meteor.

It should probably be recommended in the Meteor guide to just use storyboard images instead of setting all of the app launch sizes, as the latter is super time-consuming. Adding this to mobile-config.js gets the new sizes to work:

App.appendToConfig(`
  <platform name="ios">
    <splash src="../../../resources/splash/Default@2x~universal~anyany.png" />
    <splash src="../../../resources/splash/Default@3x~universal~anyany.png" />
  </platform>
`);

Default@2x~universal~anyany.png is size 2732x2732
Default@3x~universal~anyany.png is size 2208x2208

@markshust
Copy link

FYI the above is also required for iPhone X support -- without this setting the entire app is wonky (see #9208 for screenshots). Without this iPhone X does not work/display correctly with Meteor+Cordova.

@skirunman
Copy link
Contributor

Meteor Guide was updated to mention using Story boards, especially for iPhone X, and the definitions for the unsupported iPad Pros were removed in this commit 0ab3277 as I mentioned above.

When Xcode 11 comes out I think we will need to integrate in the version of cordova-ios that only supports Story boards.

What I would really like to see is this Feature Request implemented to decouple Cordova versions from Meteor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants