Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore wrapCallback behaviour in mongo package #10246

Merged
merged 1 commit into from Oct 3, 2018
Merged

Restore wrapCallback behaviour in mongo package #10246

merged 1 commit into from Oct 3, 2018

Conversation

janowsiany
Copy link
Contributor

Fixes #10223
What do you think on adding tests with sinon?

benjamn
benjamn approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjamn benjamn changed the base branch from devel to release-1.7.1 October 3, 2018 14:02
@benjamn benjamn merged commit c3309b1 into meteor:release-1.7.1 Oct 3, 2018
@janowsiany janowsiany deleted the restore-mongo-wrapCallback-behaviour branch October 3, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janowsiany @benjamn