Release 1.8.1

.circleci/config.yml

@@ -61,7 +61,7 @@ run_save_node_bin: &run_save_node_bin
 build_machine_environment: &build_machine_environment
   # Specify that we want an actual machine (ala Circle 1.0), not a Docker image.
   docker:
-    - image: meteor/circleci
+    - image: meteor/circleci:android-27-node-8
   environment:
     # This multiplier scales the waitSecs for selftests.
     TIMEOUT_SCALE_FACTOR: 8

CONTRIBUTING.md

@@ -44,6 +44,7 @@ Current Issue Triagers:
 - [@laosb](https://github.com/laosb)
 - [@abernix](https://github.com/abernix)
 - [@lorensr](https://github.com/lorensr)
+- [@klaussner](https://github.com/klaussner)
 
 #### Reviewer
 
@@ -53,6 +54,8 @@ Current Reviewers:
 - [@hwillson](https://github.com/hwillson)
 - [@lorensr](https://github.com/lorensr)
 - [@abernix](https://github.com/abernix)
+- [@klaussner](https://github.com/klaussner)
+- [@zodern](https://github.com/zodern)
 
 #### Core Committer
 
@@ -63,7 +66,7 @@ Project Lead: [@benjamn](https://github.com/benjamn)
 Current Core Committers:
 - [@abernix](https://github.com/abernix)
 - [@glasser](https://github.com/glasser)
-- [@stubailo](https://github.com/stubailo)
+- [@hwillson](https://github.com/hwillson)
 
 #### Documentation Maintainer
 
@@ -84,7 +87,7 @@ Current Community Package Maintainers:
 
 The community manager helps to coordinate resources, documentation, events, and other supportive work needed to ensure the health of the Meteor project.
 
-Current Community Manager:
+Previous Community Manager (this role is currently unfilled):
 - [@theadactyl](https://github.com/theadactyl)
 
 ### Tracking project work

History.md

@@ -1,13 +1,108 @@
 ## v.NEXT
 
+## v1.8.1, 2019-04-03
+
 ### Breaking changes
-N/A
 
-### Migration steps
+* Although we are not aware of any specific backwards incompatibilities,
+  the major upgrade of `cordova-android` from 6.4.0 to 7.1.4 likely
+  deserves extra attention, if you use Cordova to build Android apps.
+
+### Migration Steps
 N/A
 
 ### Changes
 
+* Node has been updated from version 8.11.4 to version
+  [8.15.1](https://nodejs.org/en/blog/release/v8.15.1/), an important
+  [security release](https://nodejs.org/en/blog/vulnerability/february-2019-security-releases/),
+  which includes the changes from four other minor releases:
+  * [8.15.0](https://nodejs.org/en/blog/release/v8.15.0/)
+  * [8.14.0](https://nodejs.org/en/blog/release/v8.14.0/), an important
+    [security release](https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/)
+  * [8.12.0](https://nodejs.org/en/blog/release/v8.12.0/)
+  * [8.13.0](https://nodejs.org/en/blog/release/v8.13.0/)
+
+  > Note: While Node 8.12.0 included changes that may improve the
+  performance of Meteor apps, there have been reports of CPU usage spikes
+  in production due to excessive garbage collection, so this version of
+  Meteor should be considered experimental until those problems have been
+  fixed. [Issue #10216](https://github.com/meteor/meteor/issues/10216)
+
+* The `npm` tool has been upgraded to version
+  [6.9.0](https://github.com/npm/cli/releases/tag/v6.9.0), and our
+  [fork](https://github.com/meteor/pacote/tree/v9.5.0-meteor) of its
+  `pacote` dependency has been updated to version 9.5.0.
+
+* Mongo has been upgraded to version 4.0.6 for 64-bit systems (was 4.0.2),
+  and 3.2.22 for 32-bit systems (was 3.2.19). The `mongodb` npm package
+  used by `npm-mongo` has been updated to version 3.1.13 (was 3.1.6).
+
+* The `fibers` npm package has been updated to version 3.1.1, a major
+  update from version 2.0.0. Building this version of `fibers` requires a
+  C++11 compiler, unlike previous versions. If you deploy your Meteor app
+  manually (without using Galaxy), you may need to update the version of
+  `g++` used when running `npm install` in the `bundle/programs/server`
+  directory.
+
+* The `meteor-babel` npm package has been updated to version 7.3.4.
+
+* Cordova Hot Code Push mechanism is now switching versions explicitly with
+  call to `WebAppLocalServer.switchToPendingVersion` instead of trying to 
+  switch every time a browser reload is detected. If you use any third 
+  party package or have your own HCP routines implemented be sure to call
+  it before forcing a browser reload. If you use the automatic reload from
+  the `Reload` meteor package you do not need to do anything.
+  [cordova-plugin-meteor-webapp PR #62](https://github.com/meteor/cordova-plugin-meteor-webapp/pull/62) 
+
+* Multiple Cordova-related bugs have been fixed, including Xcode 10 build
+  incompatibilities and hot code push errors due to duplicated
+  images/assets. [PR #10339](https://github.com/meteor/meteor/pull/10339)
+
+* The `cordova-android` and `cordova-ios` npm dependencies have been
+  updated to 7.1.4 (from 6.4.0) and 4.5.5 (from 4.5.4), respectively.
+
+* Build performance has improved (especially on Windows) thanks to
+  additional caching implemented by [@zodern](https://github.com/zodern)
+  in PRs [#10399](https://github.com/meteor/meteor/pull/10399),
+  [#10452](https://github.com/meteor/meteor/pull/10452),
+  [#10453](https://github.com/meteor/meteor/pull/10453), and
+  [#10454](https://github.com/meteor/meteor/pull/10454).
+
+* The `meteor mongo` command no longer uses the `--quiet` option, so the
+  normal startup text will be displayed, albeit without the banner about
+  Mongo's free monitoring service. See this
+  [MongoDB Jira issue](https://jira.mongodb.org/browse/SERVER-38862)
+  for more details.
+
+* In Meteor packages, `client/` and `server/` directories no longer have
+  any special meaning. In application code, `client/` directories are
+  ignored during the server build, and `server/` directories are ignored
+  during the client build, as before. This special behavior previously
+  applied to packages as well, but has now been removed.
+  [Issue #10393](https://github.com/meteor/meteor/issues/10393)
+  [PR #10414](https://github.com/meteor/meteor/pull/10414)
+
+* If your application is using Git for version control, the current Git
+  commit hash will now be exposed via the `Meteor.gitCommitHash` property
+  while the app is running (in both server and client code), and also via
+  the `"gitCommitHash"` property in the `star.json` file located in the
+  root directory of builds produced by `meteor build`, for consumption by
+  deployment tools. If you are not using Git, neither property will be
+  defined. [PR #10442](https://github.com/meteor/meteor/pull/10442)
+
+* The Meteor Tool now uses a more reliable method (the MongoDB
+  [`isMaster` command](https://docs.mongodb.com/manual/reference/command/isMaster/))
+  to detect when the local development database has started and is ready to
+  accept read and write operations.
+  [PR #10500](https://github.com/meteor/meteor/pull/10500)
+
+* Setting the `x-no-compression` request header will prevent the `webapp`
+  package from compressing responses with `gzip`, which may be useful if
+  your Meteor app is behind a proxy that compresses resources with another
+  compression algorithm, such as [brotli](https://github.com/google/brotli).
+  [PR #10378](https://github.com/meteor/meteor/pull/10378)
+
 ## v1.8.0.2, 2019-01-07
 
 ### Breaking changes
@@ -18,13 +113,13 @@ N/A
 
 ### Changes
 
-- The [React tutorial](https://www.meteor.com/tutorials/react/creating-an-app)
+* The [React tutorial](https://www.meteor.com/tutorials/react/creating-an-app)
   has been updated to address a number of inaccuracies due to changes in
   recent Meteor releases that were not fully incorporated back into the
   tutorial. As a reminder, Meteor now supports a `meteor create --react`
   command that can be used to create a new React-based app quickly.
 
-- Fixed a bug where modules named with `*.app-tests.js` (or `*.tests.js`)
+* Fixed a bug where modules named with `*.app-tests.js` (or `*.tests.js`)
   file extensions sometimes could not be imported by the
   `meteor.testModule` entry point when running the `meteor test` command
   (or `meteor test --full-app`).

meteor

@@ -1,7 +1,6 @@
 #!/usr/bin/env bash
 
-# Note: Skip 8.12.0.0, as it has already been used.
-BUNDLE_VERSION=8.11.4.8
+BUNDLE_VERSION=8.15.1.1
 
 # OS Check. Put here because here is where we download the precompiled
 # bundles that are arch specific.

packages/accounts-ui-unstyled/accounts_ui.js

@@ -4,15 +4,29 @@
  * @memberOf Accounts
  * @importFromPackage accounts-base
  */
-Accounts.ui = {};
-
-Accounts.ui._options = {
-  requestPermissions: {},
-  requestOfflineToken: {},
-  forceApprovalPrompt: {}
+Accounts.ui = {
+  _options: {
+    requestPermissions: Object.create(null),
+    requestOfflineToken: Object.create(null),
+    forceApprovalPrompt: Object.create(null),
+  },
 };
 
-// XXX refactor duplicated code in this function
+const VALID_OPTIONS = new Set()
+  .add('passwordSignupFields')
+  .add('requestPermissions')
+  .add('requestOfflineToken')
+  .add('forceApprovalPrompt');
+
+const VALID_PASSWORD_SIGNUP_FIELDS = new Set()
+  .add("USERNAME_AND_EMAIL")
+  .add("USERNAME_AND_OPTIONAL_EMAIL")
+  .add("USERNAME_ONLY")
+  .add("EMAIL_ONLY");
+
+function isValidPasswordSignupField(field) {
+  return VALID_PASSWORD_SIGNUP_FIELDS.has(field);
+}
 
 /**
  * @summary Configure the behavior of [`{{> loginButtons}}`](#accountsui).
@@ -25,86 +39,107 @@ Accounts.ui._options = {
  * @importFromPackage accounts-base
  */
 Accounts.ui.config = options => {
-  // validate options keys
-  const VALID_KEYS = ['passwordSignupFields', 'requestPermissions', 'requestOfflineToken', 'forceApprovalPrompt'];
   Object.keys(options).forEach(key => {
-    if (!VALID_KEYS.includes(key))
-      throw new Error(`Accounts.ui.config: Invalid key: ${key}`);
+    if (!VALID_OPTIONS.has(key)) {
+      throw new Error(`Accounts.ui.config: Invalid option: ${key}`);
+    }
   });
 
-  // deal with `passwordSignupFields`
-  if (options.passwordSignupFields) {
-    if (options.passwordSignupFields.reduce((prev, field) => 
-      prev && 
-      [
-        "USERNAME_AND_EMAIL",
-        "USERNAME_AND_OPTIONAL_EMAIL",
-        "USERNAME_ONLY",
-        "EMAIL_ONLY"
-      ].includes(field),
-      true
-    )) {
-      if (Accounts.ui._options.passwordSignupFields)
+  handlePasswordSignupFields(options);
+  handleRequestPermissions(options);
+  handleRequestOfflineToken(options);
+  handleForceApprovalPrompt(options);
+};
+
+function handlePasswordSignupFields(options) {
+  let { passwordSignupFields } = options;
+
+  if (passwordSignupFields) {
+    const reportInvalid = () => {
+      throw new Error(`Accounts.ui.config: Invalid option for \`passwordSignupFields\`: ${passwordSignupFields}`);
+    };
+
+    if (typeof passwordSignupFields === "string") {
+      passwordSignupFields = [passwordSignupFields];
+    } else if (!Array.isArray(passwordSignupFields)) {
+      reportInvalid();
+    }
+
+    if (passwordSignupFields.every(isValidPasswordSignupField)) {
+      if (Accounts.ui._options.passwordSignupFields) {
         throw new Error("Accounts.ui.config: Can't set `passwordSignupFields` more than once");
-      else
-        Accounts.ui._options.passwordSignupFields = options.passwordSignupFields;
-    } else {
-      throw new Error(`Accounts.ui.config: Invalid option for \`passwordSignupFields\`: ${options.passwordSignupFields}`);
+      }
+      Object.assign(Accounts.ui._options, { passwordSignupFields });
+      return;
     }
+
+    reportInvalid();
+  }
+}
+
+export function passwordSignupFields() {
+  const { passwordSignupFields } = Accounts.ui._options;
+
+  if (Array.isArray(passwordSignupFields)) {
+    return passwordSignupFields;
+  }
+
+  if (typeof passwordSignupFields === 'string') {
+    return [passwordSignupFields];
   }
 
-  // deal with `requestPermissions`
-  if (options.requestPermissions) {
-    Object.keys(options.requestPermissions).forEach(service => {
-      const scope = options.forceApprovalPrompt[service];
+  return ["EMAIL_ONLY"];
+}
+
+
+function handleRequestPermissions({ requestPermissions }) {
+  if (requestPermissions) {
+    Object.keys(requestPermissions).forEach(service => {
       if (Accounts.ui._options.requestPermissions[service]) {
         throw new Error(`Accounts.ui.config: Can't set \`requestPermissions\` more than once for ${service}`);
-      } else if (!Array.isArray(scope)) {
+      }
+
+      const scope = requestPermissions[service];
+
+      if (!Array.isArray(scope)) {
         throw new Error("Accounts.ui.config: Value for `requestPermissions` must be an array");
-      } else {
-        Accounts.ui._options.requestPermissions[service] = scope;
       }
+
+      Accounts.ui._options.requestPermissions[service] = scope;
     });
   }
+}
 
-  // deal with `requestOfflineToken`
-  if (options.requestOfflineToken) {
-    Object.keys(options.requestOfflineToken).forEach(service => {
-      const value = options.forceApprovalPrompt[service];
-      if (service !== 'google')
+function handleRequestOfflineToken({ requestOfflineToken }) {
+  if (requestOfflineToken) {
+    Object.keys(requestOfflineToken).forEach(service => {
+      if (service !== 'google') {
         throw new Error("Accounts.ui.config: `requestOfflineToken` only supported for Google login at the moment.");
+      }
 
       if (Accounts.ui._options.requestOfflineToken[service]) {
         throw new Error(`Accounts.ui.config: Can't set \`requestOfflineToken\` more than once for ${service}`);
-      } else {
-        Accounts.ui._options.requestOfflineToken[service] = value;
       }
+
+      Accounts.ui._options.requestOfflineToken[service] =
+        requestOfflineToken[service];
     });
   }
+}
 
-  // deal with `forceApprovalPrompt`
-  if (options.forceApprovalPrompt) {
-    Object.keys(options.forceApprovalPrompt).forEach(service => {
-      const value = options.forceApprovalPrompt[service];
-      if (service !== 'google')
+function handleForceApprovalPrompt({ forceApprovalPrompt }) {
+  if (forceApprovalPrompt) {
+    Object.keys(forceApprovalPrompt).forEach(service => {
+      if (service !== 'google') {
         throw new Error("Accounts.ui.config: `forceApprovalPrompt` only supported for Google login at the moment.");
+      }
 
       if (Accounts.ui._options.forceApprovalPrompt[service]) {
         throw new Error(`Accounts.ui.config: Can't set \`forceApprovalPrompt\` more than once for ${service}`);
-      } else {
-        Accounts.ui._options.forceApprovalPrompt[service] = value;
       }
-    });
-  }
-};
 
-export const passwordSignupFields = () => {
-  const { passwordSignupFields } = Accounts.ui._options;
-  if (Array.isArray(passwordSignupFields)) {
-    return passwordSignupFields;
-  } else if (typeof passwordSignupFields === 'string') {
-    return [passwordSignupFields];
+      Accounts.ui._options.forceApprovalPrompt[service] =
+        forceApprovalPrompt[service];
+    });
   }
-  return ["EMAIL_ONLY"];
 }
-

packages/accounts-ui-unstyled/package.js

@@ -1,6 +1,6 @@
 Package.describe({
   summary: "Unstyled version of login widgets",
-  version: "1.4.1"
+  version: "1.4.2"
 });
 
 Package.onUse(function (api) {