Ignore inline source maps when minifying CSS files. #10263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10112 (comment) Further down in the mergeCss function, when we call CssTools.stringifyCss, we pass the following option: // don't try to read the referenced sourcemaps from the input inputSourcemaps: false Apparently this isn't enough to avoid reading inline source maps from the input file, so we should be a bit more aggressive about preventing postcss from picking up inline source maps. This change mostly affects .css files imported from node_modules, and possibly raw .css files in the application that happen to have inline sourceMappingURL= comments. For CSS output from compiler plugins like LESS and SCSS, we have a totally different mechanism of handling source maps, namely file.getSourceMap(). Should fix #10112.
benjamn
force-pushed
the
fix-issue-10112-by-ignoring-inline-source-maps
branch
from
767daf5
to
3f30d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10112 (comment)
Further down in the
mergeCssfunction, when we callCssTools.stringifyCss, we pass the following option:Apparently this isn't enough to avoid reading inline source maps from the input file, so we should be a bit more aggressive about preventing
postcssfrom picking up inline source maps.This change mostly affects
.cssfiles imported fromnode_modules, and possibly raw.cssfiles in the application that happen to have inlinesourceMappingURL=comments. For CSS output from compiler plugins like LESS and SCSS, we have a totally different mechanism of handling source maps, namelyfile.getSourceMap().Should fix #10112.