Remove Blaze repo based dependencies from static-html #10267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes create a new copy of the static-html and caching-html-compiler packages in core, as well as a new package called html-scanner, to house the html-scanner.js functionality from the templating-tools package. With these changes in place, we're able to remove all Blaze dependencies from static-html, which benefits React based Meteor apps.
hwillson
changed the title
|
Grrr - none of these test failures happen locally 😞. |
We don't need the extra `CompileError` class, and using it was throwing off `caching-html-compiler` error handling. Errors with messages and line numbers weren't being interpreted / formatted properly.
|
This PR is now in working shape technically, but we need to decide how to best update Blaze to reference these new packages (instead of using its own copies). That decision will likely also affect the version numbers used for these packages. I'll remove the WIP and flag this as being ready for review, since the Blaze updates will happen in a separate repo/PR. |
hwillson
changed the title
benjamn
added a commit
that referenced
this pull request
Nov 23, 2018
This reverts commit 4aad077. @hwillson Travis CI tests were failing after I merged this, and now they're passing again (locally) with this commit reverted: https://travis-ci.org/meteor/meteor/builds/458921622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Replaces #9781)
meteor create --minimalpullstrackerinto new minimal apps as a dependency. This is because it's being pulled in as one of the dependencies on the Blaze templating tools side. Currently thestatic-htmlpackage is dependent on several Blaze repo based packages, a lot of which include Blaze specific utilities / helpers, that are really not needed when using non-Blaze apps. Thestatic-htmlpackage really only needs the following Blaze repo functionality to accomplish its role:caching-html-compilerhtml-scanner.jsfile from thetemplating-toolspackage.static-htmlpackage.Since the above functionality isn't specific to Blaze, let's extract those files / packages from the Blaze repo, and bring them back into Meteor core. By doing so we can reduce a lot of template based dependency overhead, when not using Blaze.
This PR creates a new copy of the
static-htmlandcaching-html-compilerpackages in core, and creates a new package calledhtml-scanner, to house thehtml-scanner.jsfunctionality from thetemplating-toolspackage. With these changes in place, we're able to replace the following dependencies in ameteor create --minimalapp:with:
(And this change will of course benefit non minimal
static-htmldependent apps as well.)