user.services is not an array. #10299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! 👍 |
|
@benjamn this bugfix was not released with 1.8.1. Can we publish a patch package? |
|
@macrozone Yes! Good catch. |
benjamn
added a commit
that referenced
this pull request
Apr 23, 2019
This should have been done when PR #10299 was first merged. Thankfully, @macrozone discovered the problem while diagnosing issue #10530. Should fix #10530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
accounts-baseintroduced by "modernization". The check whether the email address matches the restriction pattern fails currently for external login services, since it treatsuser.serviceslike an array rather than as an object.