Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for METEOR_GIT_COMMIT_HASH in lieu of findGitCommitHash's execFile #10586

Merged
merged 1 commit into from Jun 23, 2019
Merged

Allow for METEOR_GIT_COMMIT_HASH in lieu of findGitCommitHash's execFile #10586

merged 1 commit into from Jun 23, 2019

Conversation

RobertLowe
Copy link
Contributor

Straight forward, we allow for overriding gitCommitHash in lieu of findGitCommitHash

Needed when build systems don't have access to git or .git/, but commit may be known.

This could also be used as a way to set custom version numbers, although something like Meteor.appVersion may be desired.

Cheers,

  • Rob

benjamn
benjamn approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea @RobertLowe!

@benjamn benjamn changed the base branch from devel to release-1.8.2 June 23, 2019 15:54
@benjamn benjamn merged commit f214eba into meteor:release-1.8.2 Jun 23, 2019
@benjamn benjamn added this to the Release 1.8.2 milestone Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.8.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobertLowe @benjamn