Convert func-utils.js to typescript
#10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicu-chiciuc: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
Is it possible to rerun the AppVeyor check without commiting anything? |
Also removed func-utils.js from .eslintignore (since it wasn't event matched by the rule). Added `displayName` property to Function interface.
benjamn
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
Looks great with a few minor style tweaks. Thanks @nicu-chiciuc!
|
|
||
| interface Function { | ||
| // func-utils.ts makes usage of this feature | ||
| displayName?: string; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the ongoing transformation to typescript.
The pull should be accepted only after adding a
@types/underscoreto the node_modules, as mentioned in pull request 10624. Currently I've installed the types locally.Also, I've added some ad-hoc types e.g.
EmptyFunctionandAnyFunction. After the transformation will mature we can use a library for stuff like this or have a centralised way where these type shuld be defined.The global
Functioninterface was ammended to include thedisplayNameproperty.