Include Meteor.isSever constant in roadmap #10823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I (and presumably others) often have code shared between client and server, with some blocked off by `if(Meteor.isServer)` and (more rarely) `if(!Meteor.isServer)`. It would be great if this constant is also handled in the tree shaking, and I imagine it's about as easy as `Meteor.isProduction` (but slightly different so worth mentioning).
|
|
|
Could you also add: #10056 to the list of related PR's? |
|
@sebakerckhof OK, I added mention of #10056. I don't think it belongs in the "PR" field, as I assume that's reserved for the PR implementing the overall feature, and I don't think #10056 does all of tree shaking. But let me know if I'm mistaken and I should change this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I (and presumably others) often have code shared between client and server, with some blocked off by
if(Meteor.isServer)and (more rarely)if(!Meteor.isServer). It would be great if this constant is also handled in the tree shaking, and I imagine it's about as easy asMeteor.isProduction(but slightly different so worth mentioning).