Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code from before v1.0 #11226

Closed
wants to merge 74 commits into from
Closed

Remove deprecated code from before v1.0 #11226

wants to merge 74 commits into from

Conversation

StorytellerCZ
Copy link
Collaborator

  • Remove deprecated code from before Meteor 1.0 that was documented via XXX COMPAT in comments.
  • Move deprecated packages into the deprecated folder (deps, livedata, srp).

filipenevola and others added 30 commits June 23, 2020 14:12
@filipenevola
WIP dead code elimination
51e2611
@menelike
add Accounts.addDefaultPublishFields(string[]) to add additional fiel…
1d253ea 
…ds published on user login

- this is implemented in the same way of the Autopublish package in conjunction with Accounts.addAutopublishFields()
@renanccastro
Dead code elimination based on meteor build info, use babel instead o…
d717389 
…f terser for replacing nodes on AST. Also exclude case of assignment.
@renanccastro
Fix build error
be4cfbf
@menelike
refactor Accounts.addDefaultPublishFields(string[]) to Accounts.setDe…
78ea663 
…faultPublishFields(object)

Instead of extending the default projection it is overridden. Otherwise a check for mixed projections would have been necessary. In addition, replacing the default projection gives the user full control over the result.
@renanccastro
Merge branch 'devel' into dead-code-elimination
cbadc54
@renanccastro
Support for custom global flags when minifying
c310d9a
@renanccastro
Support for custom global flags when running
11fe73f
@renanccastro
Prepare a map of imports to be used inside the bundler for removing u…
c65bd60 
…nused exports
@renanccastro
Starting to remove some exports from the final bundle, there is still…
d7e2ac8 
… work to do regarding global variables and meteor packages, as they are global scoped and removing then can be troublesome.
@renanccastro
Add api for setting sideEffects on meteor modules, start the changes …
90e39f0 
…on resolver based on symbols.
@renanccastro
Using parent for deciding which files to include in the bundle in a c…
483029e 
…ase of a proxy export, now files are also "tree shaked", as well as export declarations. Working with lodash-es.
@renanccastro
Don't stop analyzing files when first found, but accumulate the symbo…
f146f28 
…ls required avoiding cycles. It was missing symbols on import scanner.
@renanccastro
Remove entires sub trees instead of only one node. Also store globall…
90ecfaa 
…y the info of imports/exports/deps for later reconciliation.
@renanccastro
When adding the import tree to the files, do not run over the same no…
9d6f99d 
…de, mark it as visited/unvisited
@renanccastro
Fix dynamic imports not working.
0aa9d4a
@renanccastro
Do not remove imports from node native modules if we are on the serve…
4e719f6 
…r bundle. Remembering that those packages are not bundled in the server build, so we need to verify them explicitly
@renanccastro
Remove log utils from tree shaking branch
cc6e08b
@renanccastro
Remove log utils from tree shaking branch
2bb3cf8
@renanccastro
Remove log utils from tree shaking branch
43c38d8
@renanccastro
Implement better logic for getting side effects. If APP doesn't say i…
b712262 
…t is side effect free, don't even try.
@renanccastro
Don't tree shake import if is native module.
7d45a7d
@renanccastro
Fix issue with dynamic imports not being included in the deps array.
58d6b49
@renanccastro
Import scanner fix for dynamic imports
4291cdb
@renanccastro
Use import status when deciding which tree to follow. Also remove sta…
61bcc48 
…tic references when only dynamic remains.
@filipenevola
Bump Meteor version to 2.0-beta.0
1c6255f
@filipenevola
Bump package versions to Meteor 2.0-beta.0
2afdc7c
@denihs
#371 cold-start
00e47f3 
-Introduce a flag --free to the clients already create apps running Tiny containers and in the free mode
@filipenevola
Merge branch 'hot-module-reload' into release-2.0
135985a
@filipenevola
Bump package versions to Meteor 2.0-beta.0
bbc88eb
@filipenevola filipenevola added pending-tests Tests are not passing, stuck or we need new tests hacktoberfest-accepted labels Oct 31, 2020
@filipenevola
Copy link
Collaborator

@StorytellerCZ any news here? Did you try to run the tests locally?

@StorytellerCZ
Copy link
Collaborator Author

Sorry, was sick. Will give it a shot this weekend.

@StorytellerCZ StorytellerCZ added the in-development We are already working on it label Dec 14, 2020
@filipenevola filipenevola modified the milestones: Release 2.0, Release 2.1 Jan 17, 2021
Base automatically changed from release-2.0 to master January 20, 2021 14:16
@StorytellerCZ StorytellerCZ changed the base branch from master to devel January 27, 2021 15:57
@filipenevola filipenevola modified the milestones: Release 2.1, Release 2.3 Feb 25, 2021
@filipenevola
Copy link
Collaborator

This branch needs to be recreated as it is including tree-shaking and other unrelated changes.

@filipenevola filipenevola removed this from the Release 2.3 milestone Apr 20, 2021
@StorytellerCZ StorytellerCZ mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie left review comments

@lgandecki lgandecki lgandecki left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted in-development We are already working on it pending-tests Tests are not passing, stuck or we need new tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@StorytellerCZ @filipenevola @radekmie @lgandecki @menelike @renanccastro @denihs