Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmr fix btoa unicode #11228

Closed
wants to merge 1 commit into from
Closed

Conversation

boomfly
Copy link
Contributor

@boomfly boomfly commented Oct 31, 2020

Recreate PR #11227

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ivan Chalyk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@filipenevola
Copy link
Collaborator

hi @boomfly can you sign the CLA? Wait in the page a little bit, then it will load and then you sign with your GitHub user.

@boomfly
Copy link
Contributor Author

boomfly commented Oct 31, 2020

hi @filipenevola, ok signed.

@zodern
Copy link
Member

zodern commented Nov 11, 2020

@boomfly #11228 (comment) says that you need to add the email address used for the commit to your GitHub account. Hopefully this will fix the CLA.

@boomfly
Copy link
Contributor Author

boomfly commented Nov 12, 2020

@zodern here my emails settings

Снимок экрана 2020-11-12 в 15 28 11

mb there some bug in CLA, i was signed it many times, but status not changed

@mattnotmitt
Copy link

mattnotmitt commented Nov 12, 2020

Hey @boomfly, I've just checked your commit patch and the email address on there isn't one of the ones that is listed in that screenshot and I'm not sure it'd be valid to associate with your github account. You could try changing the author of the commit to one of your addresses which should associate the commit with your account.

@filipenevola
Copy link
Collaborator

@zodern please reimplement this fix, we can't merge PRs without CLAs.

@filipenevola
Copy link
Collaborator

67066a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants