Fix #9960 by adding hot-code-push to minimal skelet

[StorytellerCZ]

Adding hot-code-push to minimal skeleton fixes and issue where the server would reload when a change occurred on client.

[StorytellerCZ]

@filipenevola @renanccastro what are your thoughts on this change?

[filipenevola]

I believe the root cause is the same problem that I'm fixing here #11381

This PR is going to be closed as @zodern is going to implement a different approach to solve the same issue.

@zodern do you agree with me? Because if your fix is going to fix this restart for the minimal as well, so we don't need to merge this PR.

misunderstood the change

[zodern]

Is the reason hot-code-push is missing because it increased the production bundle size?

If that is still a concern, one option might be to add Autoupdate as a dependency to hot-module-replacement (I'm not sure why it isn't already), and add hot-module-replacement instead. Since it is a debug only package, it and Autoupdate should be excluded from the production bundle. This might also solve meteor/meteor-feature-requests#354.

[zodern]

@zodern do you agree with me? Because if your fix is going to fix this restart for the minimal as well, so we don't need to merge this PR.

Meteor always does a full rebuild unless the app uses the autoupdate package:

meteor/tools/runners/run-app.js

Lines 657 to 660 in ffcfa50

	// We only can refresh the client without restarting the server if the
	// client contains the 'autoupdate' package.
	var canRefreshClient = self.projectContext.packageMap &&
	self.projectContext.packageMap.getInfo('autoupdate');

The changes I am making to watching won't change that.

[StorytellerCZ]

Changing for autoupdate package.

[StorytellerCZ]

autoupdate or hot-code-push either fix the issue. HCP refreshes the browser, autoupdate does not. The issue remains of the bundle size.

[filipenevola]

@StorytellerCZ let's resume what is going on here.

Did you try to add hot-code-push to minimal but it added more code to the bundle size, is that the issue with this approach? How much was added?

I would like to hear from people using the minimal in production. Is it a real use case? I will ask about this in our community Slack.