Revised implementation of DDP resumption

[vlasky]

Changes to DDP resumption code in response to reviewer comments on znewsham's PR #11559

• Constant MAX_QUEUE_LENGTH has been replaced with option maxMessageQueueLength
• Constant DISCONNECT_GRACE_PERIOD has been replaced with option disconnectGracePeriod
• Use of _.each() replaced with Array forEach()
• isPingPong replaced with descriptive name ignoredMsgsForSessionOutOfDateCheck

[denihs]

Hi @vlasky, this PR has tests failing. Could you address those?

Also, would you be able to add one test or two for your new code?

[denihs]

Hi, we still have tests that are failing, and those tests seem to be related to the changes.

So I'm closing this PR until someone fixes the tests.

[vlasky]

I have merged the fixes made by @StorytellerCZ. Can this PR be reopened or should I create a new one?

[StorytellerCZ]

I'm going to push the re-open button and see if it picks up the new changes and runs the tests.

[StorytellerCZ]

The error is annoying. Nothing obvious is coming up right now that would explain it, but I'm working on it.

[vlasky]

Hiya @StorytellerCZ, what needs to be addressed to allow this to be merged?

[Grubba27]

hello there! @vlasky, the changes we made in 2.8 probably will make this Travis CI pass now.

[StorytellerCZ]

@vlasky, can you merge in the release-2.7.4 branch into yours? I have already changed the target branch.

[vlasky]

@StorytellerCZ unfortunately Travis CI failed again :-(

[vlasky]

@StorytellerCZ I have merged release-2.8.1 into my ddp-resumption branch.

[StorytellerCZ]

@vlasky thank you! I'm trying to figure out why the Travis tests are failing.

[vlasky]

@StorytellerCZ I have merged release-2.9.1 into my ddp-resumption branch.

[StorytellerCZ]

Hi @vlasky, I think I will make another PR from my own branch here in the Meteor repo, so that it is easier for us to access.

[vlasky]

Hi @vlasky, I think I will make another PR from my own branch here in the Meteor repo, so that it is easier for us to access.

Yes thanks anything that will help get this deployed sooner!

[StorytellerCZ]

Superseded by #12436