[webapp] Remove underscore #12238
Open
[webapp] Remove underscore #12238
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @harryadel, awesome to see you here! |
StorytellerCZ
previously approved these changes
Oct 24, 2022
|
Sure, @harryadel, I'll look carefully at them and adjust what is needed. Again thanks a lot for the care and time spent making the PRs! |
|
I think the underscore PRs might use a second look now @StorytellerCZ @Grubba27 |
Sure! I will add them to my to-do list for the next weeks. I plan on reviewing them again and maybe working on a new release for the 2.x track with these changes as long as in the 3.x track as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the very first PR of many to come in order to purge Underscore from Meteor codebase.
I must admit @filipenevola was right and I was wrong, splitting this endeavor in multiple mini-PRs is the way to go #11869 ran into a deadlock and I couldn't figure out why it was failing, just because it worked for Blaze doesn't mean it's ought to work for Meteor so credit where it's due.
One last thing, I don't have much time available so once the PRs are created whomever is reviewing these PRs please go ahead and modify them as you see fit in order to get them merged, thanks!