Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cordova deps to latest #12518

Open
wants to merge 33 commits into
base: devel
Choose a base branch
from

Conversation

StorytellerCZ
Copy link
Collaborator

Update Cordova deps to latest versions, starting with Android version to v11 for publication on Google Store as per #12448

I have just bumped the versions at this stage, haven't had time to testing yet and I don't have the resources & time to do in-depth testing so any feedback is appreciated.

Update Cordova deps to latest versions
@matheusccastroo
Copy link
Contributor

matheusccastroo commented Feb 21, 2023

LGTM, however we will need to change how we handle the splash screens for Android. Seems that the splash tag is deprecated and won't work with Android >= 12.

Looking at the changes, we would need to set the splash as a preference tag and use the new adaptive splash screen, but this would mean that we would drop the multiple splash screens sizes (hdpi, mdpi and etc) - which would be a breaking change. Seems that cordova has a fallback for that, but I'm not sure how it works.

Will try to help here.

@StorytellerCZ
Copy link
Collaborator Author

@matheusccastroo please do any changes necessary.

@StorytellerCZ StorytellerCZ added this to the Release 2.12 milestone Apr 3, 2023
@Grubba27 Grubba27 marked this pull request as ready for review April 4, 2023 14:12
@coachdan
Copy link

@Grubba27 - Just started tracking this. Where does this stand in terms of getting it into the next release?

@Grubba27
Copy link
Contributor

Grubba27 commented May 17, 2023

Hey @coachdan this still needs implementing what @matheusccastroo said:

Looking at the changes, we would need to set the splash as a preference tag and use the new adaptive splash screen, but this would mean that we would drop the multiple splash screens sizes (hdpi, mdpi and etc) - which would be a breaking change. Seems that cordova has a fallback for that, but I'm not sure how it works.

I had not had enough time to spend on this issue, but would do something like this.

@StorytellerCZ StorytellerCZ changed the base branch from devel to release-2.13 May 25, 2023 13:14
@StorytellerCZ
Copy link
Collaborator Author

@Grubba27 can we please still get this into 2.13? It is necessary so that people can deploy to app stores.

@Grubba27
Copy link
Contributor

Still needs to solve this issue:

Looking at the changes, we would need to set the splash as a preference tag and use the new adaptive splash screen, but this would mean that we would drop the multiple splash screens sizes (hdpi, mdpi and etc) - which would be a breaking change. Seems that cordova has a fallback for that, but I'm not sure how it works.

I had not yet time because of Fibers, thought that someone of the community might help with more expertise in Cordova

@github-actions github-actions bot temporarily deployed to pull request June 30, 2023 04:49 Inactive
@matheusccastroo
Copy link
Contributor

Created a new PR to handle this issue: #12785

cc @StorytellerCZ

@osrl
Copy link

osrl commented Oct 18, 2023

How about iOS? Will it be upgraded to 7.0.1?

@Grubba27 Grubba27 changed the base branch from devel to release-2.14 November 17, 2023 14:12
@StorytellerCZ
Copy link
Collaborator Author

@Grubba27 I think we need here to sync the CircleCI commands from what was merged in #12785, then I think this will work.

@StorytellerCZ
Copy link
Collaborator Author

@osrl looking at the code, iOS is at v7.0.1, so that will definitely be in Meteor v2.14

@denihs denihs modified the milestones: Release 2.15, Release 2.16 Jan 31, 2024
@StorytellerCZ StorytellerCZ changed the base branch from release-2.14 to devel March 25, 2024 15:59
@denihs denihs modified the milestones: Release 2.16, 2.17 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cordova version is too low to deploy applications on the Play Store
9 participants