Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 3.0] - Update node to v18 #12663

Merged
merged 97 commits into from Aug 16, 2023

Conversation

matheusccastroo
Copy link
Contributor

@matheusccastroo matheusccastroo commented Jun 2, 2023

  • Update node to 16
  • Update NPM to 8
  • Update node to 18
  • Fix logic to check if a package dependencies has changed
  • Update CI images to use new node version
  • Investigate the error when trying to run the test cordova builds with server options . It seems to be related to NPM.
    • Error: [BABEL] /tools/cordova/project.js: Cannot find module '@nicolo-ribaudo/semver-v6'
    • to simulate clean your Meteor clone, and make sure to delete the dev_bundles folder
  • Fix tests that are failing on windows

This commit also removes the fork of `pacote` that Meteor used to use - hopefully, the issues that were fixed with our patch are already fixed on upstream.
Bump the `source-map` version to fix the issue: mozilla/source-map#454.

We are not updating the NPM version because there is an breaking change with the `npm config set python` which we use with `node-gyp`.
@Grubba27 Grubba27 self-assigned this Jun 2, 2023
@Grubba27 Grubba27 changed the title [Release 3.0] - Update node [Release 3.0] - Update node to v18 Jun 13, 2023
@pociej
Copy link

pociej commented Jun 23, 2023

@matheusccastroo how can I run meteor from this fork? When I try standard way to described in docs and i do ./meteor --help it gives me :

dzik in ~/Projects/meteor(update-node-18)  ./meteor --help
It's the first time you've run Meteor from a git checkout.
I will download a kit containing all of Meteor's dependencies.
#=#=-#    #
tar: Error opening archive: Unrecognized archive format
Failed to install dependency kit.

@matheusccastroo
Copy link
Contributor Author

@pociej You need to build the dev-bundle locally. You can do that by running ./scripts/generate-dev-bundle.sh (don't really remember the file name, but it's something along those lines).
After you build it, you can just run any meteor command with this branch and it will work.

// As per Npm 8, now the metadata is no longer inside .npm/package/node_modules/PACKAGE_NAME/package.json
  // now you have every metadata of every package inside .npm/package/node_modules/ at .npm/package/node_modules/.package-lock.json
@Grubba27 Grubba27 marked this pull request as ready for review August 9, 2023 12:17
@denihs denihs merged commit 86e63f3 into meteor:release-3.0 Aug 16, 2023
6 checks passed
@StorytellerCZ StorytellerCZ added this to the Release 3.0 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants