Update logging package #12669
Update logging package #12669
Conversation
StorytellerCZ
commented
Jun 5, 2023
•
StorytellerCZ
commented
- Add types to logging package
|
For some reason, tests are failing, have any idea why? |
|
Could me upping the version manually have an impact? Or maybe it doesn't like something about the types? |
Bump bundle
|
@Grubba27 can you try making a new bundle. Looks like somewhere there is issue with ansi-style which is part of chalk. I have upped it in the dev bundle to have the same version as the package. |
|
I'll do a separate PR with just the types. |
|
We will need a new bundle for 2.14, I will probably make sure that we have everything okay so that I only need to generate one bundle(the CI is annoying to work with) |
|
Dev bundle changes moved to #12832 |
These two things appear to be causing some problems with the CI.
The Meteor internals seem to have issue with chalk 5+
|
Chalk v5 might have been to much for Meteor 2.x, will do that for 3.x. I think now the tests will pass. If not then I have one more commit to throw at this that should fix it. |
|
Since is just a deps update I would send this to a RC, what do you think @StorytellerCZ ? |
|
Sure, I will have to double check the changelog for the TS types. Thought this was new here as well, but apparently not. It has been a while. |
