Bump Npm.depends packages for fetch

[jamauro]

Bump node-fetch and whatwg-fetch to the latest versions

[Grubba27]

For some reason tests are failing can you check on that?

[jamauro]

It's failing here

meteor/tools/tests/apps/dynamic-import/tests.js

Line 18 in 8818cce

return fetch(Meteor.absoluteUrl("/__meteor__/dynamic-import/fetch"), {

with

TypeError: fetch is not a function

I thought fetch was global so I'm not sure what the underlying issue is. I was hoping someone closer to the code might be able to figure it out. I suppose fetch could be explicitly imported into that test file with import { fetch } from 'meteor/fetch'.

I also noticed that the dynamic-import tests are using fetch@0.1.1 here:
https://github.com/meteor/meteor/blob/8818ccef3736f878c9744b701927768ae9b22643/tools/tests/apps/dynamic-import/.meteor/packages#L27C4-L27C4

Shouldn't this just be fetch? I'm not sure if that is intentional or an oversight.

[Grubba27]

I also noticed that the dynamic-import tests are using fetch@0.1.1 here:
https://github.com/meteor/meteor/blob/8818ccef3736f878c9744b701927768ae9b22643/tools/tests/apps/dynamic-import/.meteor/packages#L27C4-L27C4

Maybe needs to be updated ? I saw theses days a test that only passed after we updated the .meteor/package file

[Grubba27]

meteor/packages/fetch/tests/main.js

Lines 3 to 5 in 97be98e

	Tinytest.add("fetch - sanity", function (test) {
	test.equal(typeof fetch, "function");
	});

this test failed as well in the CI

[jamauro]

@Grubba27 @denihs I think I'm stuck on this PR. It looks like the fetch package is required to use ecmascript 5 syntax per Meteor's check-legacy-syntax. node-fetch has these requirements: https://github.com/node-fetch/node-fetch#loading-and-configuring-the-module

So I think the options are:

1. Remove fetch from the check-legacy-syntax.js here:

   meteor/scripts/admin/check-legacy-syntax/check-syntax.js

   Line 53 in 8818cce

   'fetch': {},

   
   so that we can use import fetch from 'node-fetch'

2. Pin fetch to node-fetch@2 and continue using const fetch = require('node-fetch'). IMO, this isn't great.

3. Another idea that y'all have :)

[jamauro]

2. Pin fetch to node-fetch@2 and continue using const fetch = require('node-fetch'). IMO, this isn't great.

I went with this option for now. If y'all have a better solution, please let me know. I don't love being pinned to version 2 of node-fetch but they do say it will continue to receive critical bug fixes and it does fix the issue I was running into.

Still it seems like Meteor should be able to use the latest and greatest. I'm sure there was a good reason to force some core packages to use ecmascript 5 – I'm guessing backwards compatibility – but maybe that restriction can/should be lifted in Meteor 3.0+? Curious to hear what y'all think.

[harryadel]

Does this mean this is closed?
#11927

[harryadel]

Do we have a release date on 2.14? cc @Grubba27 @denihs I understand 3.0 is taking most of your time but #12785 with other stuff need to be released soon and no work on 2.14 has been done so far, even the creation of a PR!

Again, thank you for your work. This is just a friendly reminder.

[StorytellerCZ]

@harryadel I will be pushing @Grubba27 to make 2.14 the Hacktoberfest release! I think it could become a nice tradition going forward.

[jamauro]

🎉