Add option to disable CORS in sockjs #12789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StorytellerCZ
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Hi @brianlukoff can you please document this in the docs as well?
|
No problem -- just added a note to the docs about this. |
StorytellerCZ
approved these changes
Sep 27, 2023
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set an environment variable
DISABLE_SOCKJS_CORSwhich activates thedisable_corsflag in sockjs. This addresses a common issue that is flagged by many vulnerability scanners, discussed in #8317.