Feature: interactive meteor create command #12803
Conversation
mr-loop-1
changed the title
|
|
…ure/interactive-meteor-create-command
…ithub.com/mr-loop-1/meteor into feature/interactive-meteor-create-command
|
Hi @StorytellerCZ , |
|
I added testing this PR to my todo's |
tools/cli/commands.js
Outdated
| const skeletonExplicitOption = AVAILABLE_SKELETONS.find(skeleton => | ||
| !!options[skeleton]); | ||
|
|
||
| if(skeletonExplicitOption) { |
There was a problem hiding this comment.
If a name is provided as an arg, the interactivity should be disabled and it use the default skeleton if non was provided. This is needed to avoid breaking scripts that use meteor create.
There was a problem hiding this comment.
@zodern Yes, that would be one of the cases where we wouldn't want to make prompts.
So, in that case, we only bring up the prompts when app name is not provided?
There was a problem hiding this comment.
@zodern Alternatively, we could have a simple info line for users when they provide an app name but no template. It could go along the lines of - no skeleton specified, using default React....
There was a problem hiding this comment.
So, in that case, we only bring up the prompts when app name is not provided?
Yes.
Showing a message like you suggest when using the default skeleton makes sense.
There was a problem hiding this comment.
@zodern made some changes
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Needs a new dev-bundle. cc @StorytellerCZ |
Closes #12791
If either or both of application name and skeleton flag is missed in the create command, there will be prompts for choosing them.