New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firstRunPromise #12824
Merged
Grubba27
merged 21 commits into
meteor:release-2.14
from
harryadel:tracker-firstRunPromise
Dec 5, 2023
Merged
Add firstRunPromise #12824
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4654adb
Allow for await-able autoruns by adding firstRunPromise to computatio…
DanielDornhardt 1a7ad0d
Merge branch 'devel' into tracker-computation-firstRunPromise
StorytellerCZ 3a8e09a
Apply @radekmie suggestions
harryadel 262a6dc
Merge branch 'devel' of github.com:harryadel/meteor into HEAD
harryadel 6106a2c
Merge branch 'devel' into tracker-firstRunPromise
Grubba27 ff615a5
[tracker] add then and catch
harryadel 2eb32ba
Merge branch 'tracker-firstRunPromise' of github.com:harryadel/meteor…
harryadel 4fc44cb
Merge branch 'devel' into tracker-firstRunPromise
StorytellerCZ f2c98ae
[tracker] await then & catch
harryadel 8223aef
Merge branch 'tracker-firstRunPromise' of github.com:harryadel/meteor…
harryadel e41c8ec
Update packages/tracker/tracker.js
harryadel 2e32f1c
[tracker] Add a test without firstRunPromise
harryadel a30c131
[tracker] attach methods without the use of 'this'
harryadel e91c5c2
Merge branch 'devel' into tracker-firstRunPromise
harryadel 8888925
Fixed missing firstRunPromise.
radekmie cc07fe5
[tracker] Remove joke because Gabriel is no fun :sob:
harryadel 8e90991
[tracker] Use of firstRunPromise is not necessary paragraph
harryadel 01acda0
Merge branch 'release-2.14' into tracker-firstRunPromise
StorytellerCZ 654f366
Merge branch 'release-2.14' into tracker-firstRunPromise
StorytellerCZ 0afa7df
Solve error in jsdoc generation
Grubba27 c47c3a1
Adjusting typo
Grubba27 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automagically
, 🤔 I really like this word. Probably a typo here, but I think this should be something we should strive for in Meteor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurs only two times in our code base, and it does not follow that much how we write our docs, but I agree. We could review our documentation guide line and make some adjustments to be more pleasing to read.
I like this writing in docs(Puns and funny comments) generally, but I need to maintain how it is today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a typo. I meant to use it since Meteor is all about that magic. Pffffft you guys won't get it!