New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underscore 1.6 #12912
Underscore 1.6 #12912
Conversation
@@ -1,14 +1,14 @@ | |||
|
|||
Package.describe({ | |||
summary: "Collection of small helpers: _.map, _.each, ...", | |||
version: '1.0.13', | |||
version: '1.6.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not feel so good doing this huge bump since we use it everywhere.
Maybe we could drop this along the release with DDP resumption 2.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 2.15 I was hoping to jump to the original plan of 1.9, I did this 1.6 as that one is the latest closest to what we have been using (and I kept in the changes that were made by MDG, after this version there doesn't seem to be a need for them anymore, but the tests disagree so I will have to look more into it).
Fyi, we face a bug on _.intersection() when going from 1.0.13 to 1.6 though, that should be fixed in 1.7. |
@goyan I'll see what I can do to update that function. I don't think I will be able to update the whole thing as, if I remember correctly, the underscore structure changed after 1.6 so I can't make a simple upgrade. |
A test related to #12798 to see if the tests can manage the first update step.