Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cordova launch screen warnings on 2.14 #12971

Merged
merged 2 commits into from Jan 30, 2024
Merged

Fix cordova launch screen warnings on 2.14 #12971

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8b2c0
fix: fix cordova warnings for launch screens when using the new splas…
matheusccastroo Jan 18, 2024
cd0f686
Merge branch 'devel' into cordova-warning-launch-screens
denihs Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/cordova/builder.js
View file
Open in desktop
Expand Up @@ -771,7 +771,7 @@ configuration. The key may be deprecated.`);
Object.keys(splashIosKeys).concat(Object.keys(splashAndroidKeys));

Object.keys(launchScreens).forEach((key) => {
if (!(key in validDevices)) {
if (!validDevices.includes(key)) {
Console.labelWarn(`${key}: unknown key in App.launchScreens \
configuration. The key may be deprecated.`);
}
Expand All @@ -780,7 +780,7 @@ configuration. The key may be deprecated.`);
if (typeof value !== "string" && key.includes("android")) {
throw new Error("Android splash screen path must be a string. To enable dark splash screens for your app, check out the android developer guide: https://developer.android.com/develop/ui/views/theming/darktheme.");
}
})
});
Object.assign(builder.imagePaths.splash, launchScreens);
},

Expand Down