Meteor 3.0 - FIX - publication handler is not being waited on #12972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Project:Mobile
Project:Examples
Project:Docs
Project:DDP
Project:Accounts:Password
Project:Webapp
Project:Mongo Driver
Project:Isobuild:Minifiers
Project:JS Environment
Project:Tool
Project:Utilities:Email
Project:Isobuild
Project:Utilities:HTTP
Project:Accounts:UI
Project:Tool:Shell
Project:Webapp:Browser Policy
Project:EJSON
Project:Release Process
Project:NPM
Project:CSS
Project:JS Environment:Typescript
Project:Dynamic Import
Project:HMR
Project:Guide
labels
…essage in queue (except when unblocked explicitily)
denihs
approved these changes
Jan 18, 2024
|
@denihs I think at least one test should be added to avoid regressions for this case, right? cc @renanccastro |
Just mentioning here that the test that fails here is the same that fails from the release-3.0 base branch, so it is not related with these changes. It also happens on a branch that I am fixing an issue for 3.x. There should be a branch that was merged against 3.0 that introduced it. release-3.0 branch failure: |
|
@denihs added a new regression test for this case |
filipenevola
requested changes
Jan 19, 2024
filipenevola
approved these changes
Jan 19, 2024
Grubba27
reviewed
Jan 22, 2024
|
Merging it since the test failing here is already solved in the 3.0 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Found this issue while seeing metrics on Monti APM with Meteor 3.
When we have an async publication handler, Meteor livedata server is not waiting for the promise resolution(either success/error) to unblock the processMessage handler.
The current behavior is like all publications are being unblocked.
This PR fixes it.