Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCDWebServer missing in cordova-plugin-meteor-webapp #12985

Merged
merged 4 commits into from Jan 30, 2024

Conversation

nachocodoner
Copy link
Member

@nachocodoner nachocodoner commented Jan 29, 2024

Report: #12946

Reproduction

image

Fix

It seems that when we migrated the cordova-plugin-meteor-webapp from its own repository to the meteor monorepo, we missed to set up the git submodule included in the other repository.

  • Add missing submodule in the cordova-plugin-meteor-webapp package
  • Test fix locally by changing .meteor/cordova-plugins file of an example app and using a local path reference
  • Publish a new version of npm cordova-plugin-meteor-webapp@2.0.4, https://www.npmjs.com/package/cordova-plugin-meteor-webapp
  • Update default references for cordova-plugin-meteor-webapp (webapp) to use newer version including missing libraries
  • Test to check if issue is fixed for a new app pointing the new npm version
    image

@nachocodoner nachocodoner marked this pull request as ready for review January 29, 2024 19:56
@denihs denihs merged commit 7b97e69 into release-2.14.1 Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants